Move overflow in InlineTextBox::adjustPosition() if it has glyph overflows

Source/core/layout/line/InlineBox.h

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 58 matching lines @@
     virtual ~InlineBox();
 
     virtual void destroy();
 
     virtual void deleteLine();
     virtual void extractLine();
     virtual void attachLine();
 
     virtual bool isLineBreak() const { return false; }
 
-    virtual void adjustPosition(LayoutUnit dx, LayoutUnit dy);
-    void adjustLogicalPosition(LayoutUnit deltaLogicalLeft, LayoutUnit deltaLogicalTop)
-    {
-        if (isHorizontal())
-            adjustPosition(deltaLogicalLeft, deltaLogicalTop);
-        else
-            adjustPosition(deltaLogicalTop, deltaLogicalLeft);
-    }
-    void adjustLineDirectionPosition(LayoutUnit delta)
-    {
-        if (isHorizontal())
-            adjustPosition(delta, 0);
-        else
-            adjustPosition(0, delta);
-    }
-    void adjustBlockDirectionPosition(LayoutUnit delta)
-    {
-        if (isHorizontal())
-            adjustPosition(0, delta);
-        else
-            adjustPosition(delta, 0);
-    }
+    // These methods are called when the caller wants to move the position of InlineBox without full layout of it.
+    // The implementation should keep all states (e.g. position of children, overflow, etc.) consistent after the move.
+    virtual void move(const LayoutSize& delta);

[leviw_travelin_and_unemployed, 2015/06/17 18:35:11]

It'd be nice if this gave some context about the notion that it's moving not
just this box, but all descendants as well.

[Xianzhu, 2015/06/17 18:51:10]

Done.

+    void moveInLogicalDirection(const LayoutSize& deltaInLogicalDirection) { move(isHorizontal() ? deltaInLogicalDirection : deltaInLogicalDirection.transposedSize()); }
+    void moveInLineDirection(LayoutUnit delta) { moveInLogicalDirection(LayoutSize(delta, LayoutUnit())); }

[leviw_travelin_and_unemployed, 2015/06/17 18:35:11]

For consistency, this should be moveInInlineDirection.

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[Xianzhu, 2015/06/17 18:51:10]

Done.

+    void moveInBlockDirection(LayoutUnit delta) { moveInLogicalDirection(LayoutSize(LayoutUnit(), delta)); }
 
     virtual void paint(const PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom);
     virtual bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom);
 
     // InlineBoxes are allocated out of the rendering partition.
     void* operator new(size_t);
     void operator delete(void*);
 
 #ifndef NDEBUG
     void showTreeForThis() const;
@@ skipping 339 matching lines @@
 
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showTree(const blink::InlineBox*);
 void showLineTree(const blink::InlineBox*);
 #endif
 
 #endif // InlineBox_h