Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: utils/pub/system_cache.dart

Issue 11830017: Fix ALL the pub tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« utils/pub/io.dart ('K') | « utils/pub/pub.dart ('k') | utils/pub/utils.dart » ('j') | utils/pub/utils.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/system_cache.dart
diff --git a/utils/pub/system_cache.dart b/utils/pub/system_cache.dart
index 5b00dc301b6415bab3992b546f426860213de86b..fd2c6536122e1329e6e1170fb44aa71ff5c82b48 100644
--- a/utils/pub/system_cache.dart
+++ b/utils/pub/system_cache.dart
@@ -72,8 +72,8 @@ class SystemCache {
var pending = _pendingInstalls[id];
if (pending != null) return pending;
- var future = id.source.installToSystemCache(id);
- always(future, () => _pendingInstalls.remove(id));
+ var future = id.source.installToSystemCache(id)
+ .whenComplete(() => _pendingInstalls.remove(id));
_pendingInstalls[id] = future;
return future;
}
« utils/pub/io.dart ('K') | « utils/pub/pub.dart ('k') | utils/pub/utils.dart » ('j') | utils/pub/utils.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698