Fix ALL the pub tests.

utils/pub/git.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Helper functionality for invoking Git.
 library git;
 
 import 'dart:async';
 import 'io.dart';
 import 'log.dart' as log;
@@ skipping 47 matching lines @@
     });
   }).then((command) {
     log.fine('Determined git command $command.');
     _gitCommandCache = command;
     return command;
   });
 }
 
 /// Checks whether [command] is the Git command for this computer.
 Future<bool> _tryGitCommand(String command) {
-  var completer = new Completer<bool>();
-
   // If "git --version" prints something familiar, git is working.
-  var future = runProcess(command, ["--version"]);
-
-  future
-    .then((results) {
-      var regex = new RegExp("^git version");
-      completer.complete(results.stdout.length == 1 &&
-                         regex.hasMatch(results.stdout[0]));
-    })
-    .catchError((err) {
-      // If the process failed, they probably don't have it.
-      completer.complete(false);
-    });
-
-  return completer.future;
+  return runProcess(command, ["--version"]).then((results) {
+    var regexp = new RegExp("^git version");
+    return results.stdout.length == 1 && regexp.hasMatch(results.stdout[0]);
+  }).catchError((err) {
+    // If the process failed, they probably don't have it.
+    return false;
+  });

[Bob Nystrom, 2013/01/09 16:49:23]

Much nicer!

 }