Issue 11830013: Revert 175632

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11830013: Revert 175632 (Closed)

Created:
7 years, 11 months ago by kaiwang

Modified:
7 years, 11 months ago

Reviewers:
jamesr

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 175632 > ThreadedTest that a non-null OutputSurface that fails initialization immediately doesn't crash > > Unit test to catch things like bug 168691 > > BUG= > > > Review URL: https://chromiumcodereview.appspot.com/11782026 The new tests this change added fail on Mac and linux TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175653

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -34 lines)			Patch
	M	cc/layer_tree_host_unittest_context.cc	View		1 chunk	+0 lines, -32 lines	0 comments	Download
	M	cc/thread_proxy.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kaiwang

7 years, 11 months ago (2013-01-09 01:38:09 UTC) #2

Message was sent while issue was closed.

Error log:
[----------] 1 test from LayerTreeHostContextTestFailsImmediately
[ RUN      ] LayerTreeHostContextTestFailsImmediately.runMultiThread
/b/build/slave/cr-mac-rel/build/src/cc/test/layer_tree_test_common.cc:440:
Failure
Failed
Test timed out
[  FAILED  ] LayerTreeHostContextTestFailsImmediately.runMultiThread (5000 ms)
[----------] 1 test from LayerTreeHostContextTestFailsImmediately (5000 ms
total)

From:
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests%...

Expand Messages | Collapse Messages