Issue 11830009: Fixes bug in painting multiple selected tabs. Specifically when

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11830009: Fixes bug in painting multiple selected tabs. Specifically when (Closed)

Created:
7 years, 11 months ago by sky

Modified:
7 years, 11 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes bug in painting multiple selected tabs. Specifically when reattaching multiple tabs we wouldn't repaint the whole tabstrip. The fix is to key off the selection model rather than the dragged property since the dragged property is updated after animations complete. BUG=167886 TEST=see bug R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175911

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/browser/ui/views/tabs/tab_strip.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/11830009/1

7 years, 11 months ago (2013-01-09 17:22:22 UTC) #3

commit-bot: I haz the power

7 years, 11 months ago (2013-01-09 22:41:26 UTC) #4

Retried try job too often on win_aura for step(s) content_browsertests

Expand Messages | Collapse Messages