Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Side by Side Diff: ash/wm/workspace/workspace.cc

Issue 11830008: ash/immersive mode: Hide the launcher when entering immersive mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: window property Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/wm/workspace/workspace.h" 5 #include "ash/wm/workspace/workspace.h"
6 6
7 #include "ash/shell_window_ids.h" 7 #include "ash/shell_window_ids.h"
8 #include "ash/wm/property_util.h" 8 #include "ash/wm/property_util.h"
9 #include "ash/wm/window_animations.h" 9 #include "ash/wm/window_animations.h"
10 #include "ash/wm/window_properties.h" 10 #include "ash/wm/window_properties.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 if (GetTrackedByWorkspace(child) && 84 if (GetTrackedByWorkspace(child) &&
85 (WorkspaceManager::IsMaximized(child) || 85 (WorkspaceManager::IsMaximized(child) ||
86 WorkspaceManager::WillRestoreMaximized(child))) { 86 WorkspaceManager::WillRestoreMaximized(child))) {
87 if (++count == 2) 87 if (++count == 2)
88 return count; 88 return count;
89 } 89 }
90 } 90 }
91 return count; 91 return count;
92 } 92 }
93 93
94 bool Workspace::IsImmersiveMode() const {
James Cook 2013/01/10 18:38:28 Does this seem OK here? It could also live in Wor
sky 2013/01/10 19:02:05 It doesn't look like the workspace code cares abou
95 for (size_t i = 0; i < window_->children().size(); ++i) {
96 aura::Window* child = window_->children()[i];
97 if (child->GetProperty(kImmersiveModeKey))
sky 2013/01/10 19:02:05 Shouldn't you check if the child is visible?
98 return true;
99 }
100 return false;
101 }
102
94 } // namespace internal 103 } // namespace internal
95 } // namespace ash 104 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698