Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: webkit/media/webmediaplayer_impl.cc

Issue 11830004: Refactor content::RenderAudioSourceProvider as webkit_media::WebAudioSourceProviderImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/media/webmediaplayer_impl.cc
diff --git a/webkit/media/webmediaplayer_impl.cc b/webkit/media/webmediaplayer_impl.cc
index 3bdda6573a0361d5dfbc941ece447a7262c5d474..b16cc47c74891ad8e2cc577d493b44abf15733d5 100644
--- a/webkit/media/webmediaplayer_impl.cc
+++ b/webkit/media/webmediaplayer_impl.cc
@@ -34,6 +34,7 @@
#include "v8/include/v8.h"
#include "webkit/media/buffered_data_source.h"
#include "webkit/media/filter_helpers.h"
+#include "webkit/media/webaudiosourceprovider_impl.h"
#include "webkit/media/webmediaplayer_delegate.h"
#include "webkit/media/webmediaplayer_params.h"
#include "webkit/media/webmediaplayer_proxy.h"
@@ -140,8 +141,6 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
media_log_(params.media_log()),
accelerated_compositing_reported_(false),
incremented_externally_allocated_memory_(false),
- audio_source_provider_(params.audio_source_provider()),
- audio_renderer_sink_(params.audio_renderer_sink()),
is_local_source_(false),
supports_save_(true),
starting_(false) {
@@ -199,13 +198,11 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
proxy_->set_frame_provider(video_renderer);
// Create default audio renderer using the null sink if no sink was provided.
- scoped_refptr<media::AudioRendererSink> audio_renderer_sink =
- params.audio_renderer_sink();
- if (!audio_renderer_sink)
- audio_renderer_sink = new media::NullAudioSink();
-
+ audio_source_provider_ = new WebAudioSourceProviderImpl(
+ params.audio_renderer_sink() ? params.audio_renderer_sink() :
+ new media::NullAudioSink());
filter_collection_->AddAudioRenderer(new media::AudioRendererImpl(
- audio_renderer_sink, set_decryptor_ready_cb));
+ audio_source_provider_, set_decryptor_ready_cb));
}
WebMediaPlayerImpl::~WebMediaPlayerImpl() {

Powered by Google App Engine
This is Rietveld 408576698