Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 118298: Add unit_tests (Chrome browser unit tests) to Mac/Linux coverage.... (Closed)

Created:
10 years, 2 months ago by John Grabowski
Modified:
8 years, 1 month ago
Reviewers:
Randall Spangler
CC:
chromium-reviews_googlegroups.com, TVL
Visibility:
Public.

Description

Add unit_tests (Chrome browser unit tests) to Mac/Linux coverage. Minor fixes to coverage related scripts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17785

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -26 lines) Patch
M build/linux/chrome_linux.croc View 1 chunk +1 line, -1 line 0 comments Download
M build/mac/chrome_mac.croc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/lcov/bin/mcov View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/code_coverage/coverage_posix.py View 7 chunks +63 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
John Grabowski
10 years, 2 months ago (2009-06-05 03:11:34 UTC) #1
Randall Spangler
LGTM What additional source directories should Croc look at now? We'll need to change build/linux/chrome_linux.croc ...
10 years, 2 months ago (2009-06-05 16:18:57 UTC) #2
John Grabowski
10 years, 2 months ago (2009-06-05 19:38:08 UTC) #3
On 2009/06/05 16:18:57, Randall Spangler wrote:
> LGTM
> 
> What additional source directories should Croc look at now?  We'll need to
> change build/linux/chrome_linux.croc and build/mac/chrome_mac.croc to include
> those.

Croc files updated; please re-review.
Where would I add a new "root" to handle the V8 files compiled with "-I." ?

Powered by Google App Engine
This is Rietveld 408576698