public/platform/modules/bluetooth/WebBluetooth.h - Issue 1182973002: Implement the Blink side of RequestDeviceOptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/modules/bluetooth/WebBluetooth.h

Issue 1182973002: Implement the Blink side of RequestDeviceOptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@pinned

Patch Set: Prepare readValue.html for a mock data change Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/bluetooth/RequestDeviceOptions.idl ('K') | « Source/modules/modules.gypi ('k') | public/platform/modules/bluetooth/WebRequestDeviceOptions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: public/platform/modules/bluetooth/WebBluetooth.h

diff --git a/public/platform/modules/bluetooth/WebBluetooth.h b/public/platform/modules/bluetooth/WebBluetooth.h

index ef959057e3abaf28907dbcdb46269235bbb0c937..af88258b3ddd10c45776b4de91e21b597a174ca8 100644

--- a/public/platform/modules/bluetooth/WebBluetooth.h

+++ b/public/platform/modules/bluetooth/WebBluetooth.h

@@ -16,6 +16,7 @@ struct WebBluetoothError;

struct WebBluetoothGATTCharacteristic;

struct WebBluetoothGATTRemoteServer;

struct WebBluetoothGATTService;

+struct WebRequestDeviceOptions;

// Success and failure callbacks for requestDevice.

// WebBluetoothDevice and WebBluetoothError object ownership is transferred.

@@ -44,7 +45,10 @@ public:

// BluetoothDiscovery Methods:

// See https://webbluetoothcg.github.io/web-bluetooth/#idl-def-bluetoothdiscovery

// WebBluetoothRequestDeviceCallbacks ownership transferred to the client.

- virtual void requestDevice(WebBluetoothRequestDeviceCallbacks*) = 0;

+ virtual void requestDevice(const WebRequestDeviceOptions&, WebBluetoothRequestDeviceCallbacks* callbacks) { requestDevice(callbacks); }

+ // TODO(jyasskin): Remove this overload after

+ // https://codereview.chromium.org/1172853004/ lands.

+ virtual void requestDevice(WebBluetoothRequestDeviceCallbacks*) { }

// BluetoothDevice methods:

// See https://webbluetoothcg.github.io/web-bluetooth/#idl-def-bluetoothdevice