Source/modules/bluetooth/RequestDeviceOptions.idl - Issue 1182973002: Implement the Blink side of RequestDeviceOptions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/bluetooth/RequestDeviceOptions.idl

Issue 1182973002: Implement the Blink side of RequestDeviceOptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@pinned

Patch Set: Prepare readValue.html for a mock data change Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://webbluetoothcg.github.io/web-bluetooth/#idl-def-requestdeviceoptions

	6

	7 dictionary RequestDeviceOptions {

	8 required sequence<BluetoothScanFilter> filters;

	9 sequence<BluetoothServiceUUID> optionalServices/* = []*/;
	ortuno 2015/06/24 19:35:51 Do you know if a dictionary can have sequence of u Do you know if a dictionary can have sequence of unions? I tried to replace BluetoothServiceUUID with 'String or unsigned long' and it's not generating the right code. Jeffrey Yasskin 2015/06/24 22:33:30 WebIDL doesn't say anything about it not working, Show quoted text On 2015/06/24 19:35:51, ortuno wrote: > Do you know if a dictionary can have sequence of unions? I tried to replace > BluetoothServiceUUID with 'String or unsigned long' and it's not generating the > right code. WebIDL doesn't say anything about it not working, but Blink's IDL compiler could be broken. I think you would need to write "sequence<(String or unsigned long)>".
	10 // TODO: Fix https://crbug.com/500638 and uncomment the default value above.

	11 };

OLD	NEW

« no previous file with comments | « Source/modules/bluetooth/BluetoothScanFilter.idl ('k') | Source/modules/modules.gypi » ('j') | no next file with comments »