Roll Win-Clang 238562:239639

Roll Win-Clang 238562:239639

This picks up several fixes related to dllexport on explicit
instantiation definitions, and name lookup in dependent base
classes.

BUG=82385, 492283
TBR=thakis

Committed: https://chromium.googlesource.com/chromium/src/+/b8cce88bf27fe0bb4614c401d7c5bdbf193c587f

[hans, 2015-06-12 23:32:45]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2015-06-12 23:33:05]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2015-06-12 23:36:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182953002/1

[hans, 2015-06-12 23:47:02]

Committed patchset #1 (id:1) manually as
b8cce88bf27fe0bb4614c401d7c5bdbf193c587f (presubmit successful).

[hans, 2015-06-13 00:02:20]

Hmm, first build failed:
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/1372/step...

Which is weird because that compiles fine locally with this new clang :-/

[hans, 2015-06-13 00:15:05]

This one got past that file just fine, though:
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28shared%29/buil...

I'll leave the roll in for a bit to see how more of the bots handle it.

[hans, 2015-06-13 00:23:15]

Clobbered build on the first buildbot doesn't help:
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/1374/step...

[hans, 2015-06-13 00:37:43]

Aha! The failing buildbot is doing Official builds. I didn't do that locally.

Official builds pass /GL. Turns out pcc hooked that up to -flto in Clang
r239213.

[hans, 2015-06-13 01:09:21]

On 2015/06/13 00:37:43, hans wrote:
> Aha! The failing buildbot is doing Official builds. I didn't do that locally.
> 
> Official builds pass /GL. Turns out pcc hooked that up to -flto in Clang
> r239213.

Fix idea: https://codereview.chromium.org/1186743002/

I'll leave the roll in since this only affects official builds, which developers
are unlikely to use.

[Nico, 2015-06-13 01:38:04]

Sounds like we should revert pccs thing then?
On Jun 12, 2015 5:37 PM, <hans@chromium.org> wrote:

> Aha! The failing buildbot is doing Official builds. I didn't do that
> locally.
>
> Official builds pass /GL. Turns out pcc hooked that up to -flto in Clang
> r239213.
>
> https://codereview.chromium.org/1182953002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.