Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(152)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1182933004: Split up inspector interfaces to CSSParser::parse(Sheet/DeclarationList) (Closed)

Created:
4 years, 10 months ago by Timothy Loh
Modified:
4 years, 10 months ago
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, blink-reviews-css, devtools-reviews_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Split up inspector interfaces to CSSParser::parse(Sheet/DeclarationList) This patch separates the parseSheet and parseDeclarationList functions into two functions, one for regular use and one for the inspector. The interfaces are slightly different, in particular with the inspector's interface not requiring a MutableStylePropertySet/StyleSheetContents, so this makes it clear that we don't need to create dummy objects. BUG=489144 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -26 lines) Patch
M Source/core/css/StylePropertySet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSParser.h View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSParser.cpp View 2 chunks +12 lines, -8 lines 0 comments Download
M Source/core/css/parser/CSSParserImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 7 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Timothy Loh
4 years, 10 months ago (2015-06-15 05:04:15 UTC) #2
rune
lgtm
4 years, 10 months ago (2015-06-16 08:16:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182933004/1
4 years, 10 months ago (2015-06-16 23:55:30 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-17 00:57:26 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197218

Powered by Google App Engine
This is Rietveld 408576698