Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1182913004: Add a metric for autofilled Android credentials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Forgot about enum. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index f956cff2a0b6455d02a7125daacbc0244449c501..17159469bc9fa5467c59bb0e0264aae1660d2084 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -27498,6 +27498,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="PasswordManager.OfferedToFillAndroidCredentials"
+ enum="PasswordManagerFillAndroidCredentials">
+ <owner>msramek@chromium.org</owner>
+ <owner>engedy@chromium.org</owner>
+ <summary>
+ When offering to fill the username and password, whether at least one of the
+ credentials in the dropdown come from an Android app.
vabr (Chromium) 2015/06/18 13:21:47 Please double-check if it should be "come" or "com
msramek 2015/06/18 14:22:27 Sorry, I just messed up. It's not conjunctive or a
vabr (Chromium) 2015/06/18 15:59:03 Acknowledged.
+ </summary>
+</histogram>
+
<histogram name="PasswordManager.OsPasswordStatus"
enum="PasswordManagerOsPasswordStatus">
<owner>dubroy@chromium.org</owner>
@@ -62121,6 +62131,11 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="1" label="A password change form"/>
</enum>
+<enum name="PasswordManagerFillAndroidCredentials" type="int">
+ <int value="0" label="Credentials NOT from Android"/>
vabr (Chromium) 2015/06/18 13:21:47 Would "No credentials from Android" "At least one
msramek 2015/06/18 14:22:27 Ah, thanks. I wanted to use very general wording,
vabr (Chromium) 2015/06/18 15:59:03 Acknowledged.
+ <int value="1" label="Credentials from Android"/>
+</enum>
+
<enum name="PasswordManagerOsPasswordStatus" type="int">
<int value="0" label="Unknown"/>
<int value="1" label="Unsupported platform"/>

Powered by Google App Engine
This is Rietveld 408576698