Cleaning up unittest configurations

pkg/unittest/lib/src/config.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of unittest;
 
 /**
  * Hooks to configure the unittest library for different platforms. This class
  * implements the API in a platform-independent way. Tests that want to take
  * advantage of the platform can create a subclass and override methods from
@@ skipping 20 matching lines @@
 
   /**
    * Called as soon as the unittest framework becomes initialized. This is done
    * even before tests are added to the test framework. It might be used to
    * determine/debug errors that occur before the test harness starts executing.
    * It is also used to tell the vm or browser that tests are going to be run
    * asynchronously and that the process should wait until they are done.
    */
   void onInit() {
     _receivePort = new ReceivePort();
-    _postMessage('unittest-suite-wait-for-done');
+    notifyController('unittest-suite-wait-for-done');
   }
 
   /** Called as soon as the unittest framework starts running. */
   void onStart() {}
 
   /**
    * Called when each test starts. Useful to show intermediate progress on
    * a test suite.
    */
   void onTestStart(TestCase testCase) {
@@ skipping 35 matching lines @@
   }
 
   /**
    * Called with the result of all test cases. The default implementation prints
    * the result summary using the built-in [print] command. Browser tests
    * commonly override this to reformat the output.
    *
    * When [uncaughtError] is not null, it contains an error that occured outside
    * of tests (e.g. setting up the test).
    */
-  void onDone(int passed, int failed, int errors, List<TestCase> results,
+  void onSummary(int passed, int failed, int errors, List<TestCase> results,
       String uncaughtError) {
     // Print each test's result.
     for (final t in _tests) {
       var resultString = "${t.result}".toUpperCase();
       print('$resultString: ${t.description}');
 
       if (t.message != '') {
         print(_indent(t.message));
       }
 
@@ skipping 11 matching lines @@
       // This is considered a failure too.
     } else if (failed == 0 && errors == 0 && uncaughtError == null) {
       print('All $passed tests passed.');
       success = true;
     } else {
       if (uncaughtError != null) {
         print('Top-level uncaught error: $uncaughtError');
       }
       print('$passed PASSED, $failed FAILED, $errors ERRORS');
     }
+  }
 
+  /**
+   * Called when the unittest framework is done running. [success] indicates
+   * whether all tests passed successfully.
+   */
+  void onDone(bool success) {
     if (success) {
-      _postMessage('unittest-suite-success');
-    _receivePort.close();
+      notifyController('unittest-suite-success');
+      _receivePort.close();
     } else {
-    _receivePort.close();
+      _receivePort.close();
       throw new Exception('Some tests failed.');
     }
   }
 
   String _indent(String str) {
     // TODO(nweiz): Use this simpler code once issue 2980 is fixed.
     // return str.replaceAll(new RegExp("^", multiLine: true), "  ");
 
     return Strings.join(str.split("\n").mappedBy((line) => "  $line"), "\n");
   }
 
   /** Handle errors that happen outside the tests. */
   // TODO(vsm): figure out how to expose the stack trace here
   // Currently e.message works in dartium, but not in dartc.
   handleExternalError(e, String message) =>
       _reportTestError('$message\nCaught $e', '');
 
-  _postMessage(String message) {
+  /**
+   * Send messages to the test controller code (see 'test_controller.js'). This
+   * is only needed to support browser tests with dart2js. Note: we could wrap
+   * tests and send the appropriate messages to the controller through the
+   * wrapper, but using wrappers has a noticeable overhead in the testing bots,
+   * so we use this approach instead.
+   *
+   * Configurations that will not run in DRT (such as vm_config and
+   * compact_vm_config), can safely override this method to avoid printing extra
+   * mesages in the console.
+   */
+  void notifyController(String message) {
     // In dart2js browser tests, the JavaScript-based test controller
     // intercepts calls to print and listens for "secret" messages.
     print(message);
   }
 }