Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 11829044: Revert 175644 (Closed)

Created:
7 years, 11 months ago by Jun Mukai
Modified:
7 years, 11 months ago
Reviewers:
sschmitz
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Revert 175644 > Solution: the popup keeps mouse capture, so that any mouse click closes it (via WebKit's WebPopupMenuImpl.cpp) not just clicks in it or in its browser window. > > BUG=161129 > TEST=navigate to > http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_select > Click on the "car name" to bring up the pop-up. > Click outside the browser window to see it close (just as for clicking inside the browser window) > > > Review URL: https://chromiumcodereview.appspot.com/11675002 TBR=sschmitz@chromium.org BUG=169115, 161129 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Jun Mukai
7 years, 11 months ago (2013-01-10 00:52:48 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698