chrome/browser/ui/views/javascript_app_modal_dialog_views.cc - Issue 11829040: Fix the content_browsertests everywhere maybe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

Issue 11829040: Fix the content_browsertests everywhere maybe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: And fix the final ExtensionApiTest.AlertBasic case. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

diff --git a/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc b/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

index d324d37781fb1659e966a140bb9fd0bbc8ab1367..d715b0527804ad761d1c4713f939e7c563b292ad 100644

--- a/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

+++ b/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

@@ -162,6 +162,9 @@ NativeAppModalDialog* NativeAppModalDialog::CreateNativeJavaScriptPrompt(

JavaScriptAppModalDialog* dialog,

gfx::NativeWindow parent_window) {

JavaScriptAppModalDialogViews* d = new JavaScriptAppModalDialogViews(dialog);

- views::Widget::CreateWindowWithParent(d, parent_window);

+ if (parent_window)

+ views::Widget::CreateWindowWithParent(d, parent_window);

+ else

+ views::Widget::CreateWindow(d);

return d;

}