Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: ui/views/widget/native_widget_aura.cc

Issue 11829040: Fix the content_browsertests everywhere maybe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Patch cleanup Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/desktop_aura/desktop_stacking_client.cc ('k') | ui/views/widget/widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_aura.cc
diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc
index 508948552145be5bec03606cec3bbfb3dcd34c6e..1888378a3538f3c3f5b8f965a34fe95b172f362b 100644
--- a/ui/views/widget/native_widget_aura.cc
+++ b/ui/views/widget/native_widget_aura.cc
@@ -136,15 +136,8 @@ void NativeWidgetAura::InitNativeWidget(const Widget::InitParams& params) {
if (parent) {
parent->AddChild(window_);
} else {
- // TODO(erg): Once I've threaded context through chrome, uncomment this
- // check, which currently fails on the NULL == NULL case.
- //
- // DCHECK_NE(params.GetParent(), params.context);
Elliot Glaysher 2013/01/14 22:56:39 This DCHECK_NE is probably incorrect; just up-func
-
- // TODO(erg): Remove this NULL check once we've made everything in views
- // actually pass us a context.
- aura::RootWindow* root_window = context ? context->GetRootWindow() : NULL;
- window_->SetDefaultParentByRootWindow(root_window, window_bounds);
+ window_->SetDefaultParentByRootWindow(context->GetRootWindow(),
+ window_bounds);
}
// Wait to set the bounds until we have a parent. That way we can know our
« no previous file with comments | « ui/views/widget/desktop_aura/desktop_stacking_client.cc ('k') | ui/views/widget/widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698