Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: chrome/browser/ui/views/simple_message_box_views.cc

Issue 11829040: Fix the content_browsertests everywhere maybe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix SimpleMessageBoxViews asan failure. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/simple_message_box_views.cc
diff --git a/chrome/browser/ui/views/simple_message_box_views.cc b/chrome/browser/ui/views/simple_message_box_views.cc
index f87e526336650b8b424c4b3c73e99138ea034adc..2faa66fc88f0f281811bc29518375ccd93f94cb5 100644
--- a/chrome/browser/ui/views/simple_message_box_views.cc
+++ b/chrome/browser/ui/views/simple_message_box_views.cc
@@ -167,7 +167,10 @@ MessageBoxResult ShowMessageBox(gfx::NativeWindow parent,
scoped_refptr<SimpleMessageBoxViews> dialog(
new SimpleMessageBoxViews(title, message, type));
- views::Widget::CreateWindowWithParent(dialog, parent)->Show();
+ if (parent)
+ views::Widget::CreateWindowWithParent(dialog, parent)->Show();
+ else
+ views::Widget::CreateWindow(dialog)->Show();
Elliot Glaysher 2013/01/14 23:15:19 This is a common thing that I've found: an interfa
Ben Goodger (Google) 2013/01/15 18:19:52 Yeah see my comment on the earlier file.
#if defined(USE_AURA)
// Use the widget's window itself so that the message loop

Powered by Google App Engine
This is Rietveld 408576698