webkit/glue/memory_usage.h - Issue 11829032: Add a histogram for renderer memory usage.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webkit/glue/memory_usage.h

Issue 11829032: Add a histogram for renderer memory usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef WEBKIT_GLUE_MEMORY_USAGE_H_

	6 #define WEBKIT_GLUE_MEMORY_USAGE_H_

	7

	8 #include <cstring>

	9

	10 #include "webkit/glue/webkit_glue_export.h"

	11

	12 namespace webkit_glue {

	13

	14 WEBKIT_GLUE_EXPORT size_t memoryUsageKB();
	Charlie Reis 2013/01/14 19:59:31 Presumably you're accounting for the fact that it' Presumably you're accounting for the fact that it's a different measurement on each platform. Maybe it's worth documenting here what this value is specifically returning for each platform? marja 2013/01/14 20:17:01 Yes, we're not comparing these values across platf Show quoted text On 2013/01/14 19:59:31, creis wrote: > Presumably you're accounting for the fact that it's a different measurement on > each platform. Maybe it's worth documenting here what this value is > specifically returning for each platform? Yes, we're not comparing these values across platforms. Added here: // Returns an estimate of the memory usage of the renderer process. Different // platforms implement this function differently, and count in different // allocations. Results are not comparable across platforms. The estimate is // computed inside the sandbox and thus its not always accurate.
	15

	16 } // namespace webkit_glue

	17

	18 #endif // WEBKIT_GLUE_MEMORY_USAGE_H_

OLD	NEW