[Android] Generate grd files for M25 translations.

[Android] Generate grd files for translations.

This generates grd files from the three strings.xml files, as part of
translating the strings.xml strings. This also adds empty translation
files (xtb files) so that the grd files can be successfully built even
before real translations are available.

BUG=165551
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175891

[newt (away), 2013-01-09 00:21:58]

Ready for review.

[Yaron, 2013-01-09 01:37:23]

On 2013/01/09 00:23:58, newt wrote:

I'm a little confused. Will these files eventually be populated as part of the
translation process and checked-in? They're just stubs for now?

[newt (away), 2013-01-09 01:48:40]

On 2013/01/09 01:37:23, Yaron wrote:
> On 2013/01/09 00:23:58, newt wrote:
> 
> I'm a little confused. Will these files eventually be populated as part of the
> translation process and checked-in? They're just stubs for now?

Exactly. The real xtbs will be generated from the output of the translation
console. In the meantime, the stub xtbs allow one to successfully run

    tools/grit/grit.py -i chrome/android/java/strings/android_chrome_strings.grd
build -o chrome/android/java/strings/res

which generates the localized strings.xml files. Of course, with the stub xtbs,
the localized strings.xml files will just contain the original English strings.

[Yaron, 2013-01-09 18:49:15]

lgtm

[commit-bot: I haz the power, 2013-01-09 19:17:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/11829009/1

[cjhopman, 2013-01-09 19:25:53]

lgtm

[commit-bot: I haz the power, 2013-01-09 21:42:20]

Change committed as 175891

[Nico, 2014-01-06 21:26:50]

https://chromiumcodereview.appspot.com/11829009/diff/1/chrome/android/java/st...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/11829009/diff/1/chrome/android/java/st...
chrome/android/java/strings/android_chrome_strings.grd:77: <outputs>
The vast majority of grd files puts "<outputs>" as first element – is a reason
this grd file deviates from that?

[newt (away), 2014-01-06 22:24:26]

On 2014/01/06 21:26:50, Nico wrote:
>
https://chromiumcodereview.appspot.com/11829009/diff/1/chrome/android/java/st...
> File chrome/android/java/strings/android_chrome_strings.grd (right):
> 
>
https://chromiumcodereview.appspot.com/11829009/diff/1/chrome/android/java/st...
> chrome/android/java/strings/android_chrome_strings.grd:77: <outputs>
> The vast majority of grd files puts "<outputs>" as first element – is a reason
> this grd file deviates from that?

No particular reason. tools/grit/grit/tool/android2grd.py happens to put the
<outputs> element at the end and that's what I used to generate these .grd
files.

Is this inconsistency causing complications somewhere? We can certainly change
these .grd files in any case.

[Nico, 2014-01-06 22:28:33]

On Mon, Jan 6, 2014 at 2:24 PM, <newt@chromium.org> wrote:

> On 2014/01/06 21:26:50, Nico wrote:
>
> https://chromiumcodereview.appspot.com/11829009/diff/1/
> chrome/android/java/strings/android_chrome_strings.grd
>
>> File chrome/android/java/strings/android_chrome_strings.grd (right):
>>
>
>
> https://chromiumcodereview.appspot.com/11829009/diff/1/
> chrome/android/java/strings/android_chrome_strings.grd#newcode77
>
>> chrome/android/java/strings/android_chrome_strings.grd:77: <outputs>
>> The vast majority of grd files puts "<outputs>" as first element – is a
>> reason
>> this grd file deviates from that?
>>
>
> No particular reason. tools/grit/grit/tool/android2grd.py happens to put
> the
> <outputs> element at the end and that's what I used to generate these .grd
> files.
>
> Is this inconsistency causing complications somewhere? We can certainly
> change
> these .grd files in any case.
>

No technical complications, but I just read all grd files for something and
it threw me off a bit. It'd be nice if things were consistent is all :-)

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[newt (away), 2014-01-06 22:50:48]

On 2014/01/06 22:28:33, Nico wrote:
> On Mon, Jan 6, 2014 at 2:24 PM, <mailto:newt@chromium.org> wrote:
> 
> > On 2014/01/06 21:26:50, Nico wrote:
> >
> > https://chromiumcodereview.appspot.com/11829009/diff/1/
> > chrome/android/java/strings/android_chrome_strings.grd
> >
> >> File chrome/android/java/strings/android_chrome_strings.grd (right):
> >>
> >
> >
> > https://chromiumcodereview.appspot.com/11829009/diff/1/
> > chrome/android/java/strings/android_chrome_strings.grd#newcode77
> >
> >> chrome/android/java/strings/android_chrome_strings.grd:77: <outputs>
> >> The vast majority of grd files puts "<outputs>" as first element – is a
> >> reason
> >> this grd file deviates from that?
> >>
> >
> > No particular reason. tools/grit/grit/tool/android2grd.py happens to put
> > the
> > <outputs> element at the end and that's what I used to generate these .grd
> > files.
> >
> > Is this inconsistency causing complications somewhere? We can certainly
> > change
> > these .grd files in any case.
> >
> 
> No technical complications, but I just read all grd files for something and
> it threw me off a bit. It'd be nice if things were consistent is all :-)
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

I just uploaded https://codereview.chromium.org/101463006/ which moves up the
<outputs> element as suggested here.

[Nico, 2014-01-06 22:55:40]

Thanks! Does it make sense to change android2grd.py as well?


On Mon, Jan 6, 2014 at 2:50 PM, <newt@chromium.org> wrote:

> On 2014/01/06 22:28:33, Nico wrote:
>
>  On Mon, Jan 6, 2014 at 2:24 PM, <mailto:newt@chromium.org> wrote:
>>
>
>  > On 2014/01/06 21:26:50, Nico wrote:
>> >
>> > https://chromiumcodereview.appspot.com/11829009/diff/1/
>> > chrome/android/java/strings/android_chrome_strings.grd
>> >
>> >> File chrome/android/java/strings/android_chrome_strings.grd (right):
>> >>
>> >
>> >
>> > https://chromiumcodereview.appspot.com/11829009/diff/1/
>> > chrome/android/java/strings/android_chrome_strings.grd#newcode77
>> >
>> >> chrome/android/java/strings/android_chrome_strings.grd:77: <outputs>
>> >> The vast majority of grd files puts "<outputs>" as first element – is a
>> >> reason
>> >> this grd file deviates from that?
>> >>
>> >
>> > No particular reason. tools/grit/grit/tool/android2grd.py happens to
>> put
>> > the
>> > <outputs> element at the end and that's what I used to generate these
>> .grd
>> > files.
>> >
>> > Is this inconsistency causing complications somewhere? We can certainly
>> > change
>> > these .grd files in any case.
>> >
>>
>
>  No technical complications, but I just read all grd files for something
>> and
>> it threw me off a bit. It'd be nice if things were consistent is all :-)
>>
>
>  To unsubscribe from this group and stop receiving emails from it, send an
>>
> email
>
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>
> I just uploaded https://codereview.chromium.org/101463006/ which moves up
> the
> <outputs> element as suggested here.
>
> https://chromiumcodereview.appspot.com/11829009/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[newt (away), 2014-01-06 23:15:24]

On 2014/01/06 22:55:40, Nico wrote:
> Thanks! Does it make sense to change android2grd.py as well?

Yes, I think so. Addressed here: https://codereview.chromium.org/101463006/