Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1182893005: Update V8 to version 4.5.56. (Closed)

Created:
5 years, 6 months ago by v8-autoroll
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update V8 to version 4.5.56. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fffc68e8..cb392cb0 Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Committed: https://crrev.com/a08e761a4a4f5c863682a39e234b4ca3af170159 Cr-Commit-Position: refs/heads/master@{#334571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
v8-autoroll
5 years, 6 months ago (2015-06-16 00:46:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182893005/1
5 years, 6 months ago (2015-06-16 00:47:21 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/70041)
5 years, 6 months ago (2015-06-16 03:23:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182893005/1
5 years, 6 months ago (2015-06-16 06:55:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 09:13:36 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a08e761a4a4f5c863682a39e234b4ca3af170159 Cr-Commit-Position: refs/heads/master@{#334571}
5 years, 6 months ago (2015-06-16 09:14:33 UTC) #9
Zhenyao Mo
5 years, 6 months ago (2015-06-16 16:57:46 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1189863003/ by zmo@chromium.org.

The reason for reverting is: Broke WebGL 2 conformance tests

Fatal error in ../../v8/src/ic/stub-cache.h, line 111
# Check failed: name->HasHashCode().

build chrome, run with --enable-unsafe-es3-apis

goto
https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html

select Version 2.0.0 (beta) in the dropbox, and run samplerobejct.html (may need
to run twice).

Powered by Google App Engine
This is Rietveld 408576698