Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Issue 1182823006: Roll PDFium to 2ca8fcb (Closed)

Created:
5 years, 6 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium to 2ca8fcb 2ca8fcb Separate agg-authored code from fx-authored code. ea44bd0 Add constructor for CPDF_ColorSpace. 5fef754 Make CPDF_PageModuleDef and CPDF_RenderModuleDef pure virtual. 0ef0de5 Do some IWYU cleanups. 9869e67 Provide a constructor for CPDF_CountedObject. 38f5c33 Remove some dead code. 8bd0964 Fix -Winconsistent-missing-override warnings. 1972b16 Remove unneeded checks in CPDF_DocPageData::GetFontFileStreamAcc(). 3218fff Corpus tests check for unexpected successes. d9e1477 Remove trailing whitespaces in core. f25db68 Remove unused reflow code. cf2e4c3 Remove trailing whitespaces in fpdfsdk. 864773a Correct unexpected hinting fonts eda2027 Cleanup: Get this rid of "this->" in fpdfsdk/ 677b8ff Kill FXSYS_mem{cpy,cmp,set.move}{32,8}. 2b5e0d5 Cleanup: Remove uses of "this->" in core/ f726c92 Convert CPDF_FontFileMap to std::map. 7771364 Convert CPDF_IccProfileMap to use std::map. TBR=tsepez@chromium.org BUG=490814 Committed: https://crrev.com/e44c8b2620991646c8e5fb06e5ab8f61a395b928 Cr-Commit-Position: refs/heads/master@{#334926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
Lei Zhang
TBR
5 years, 6 months ago (2015-06-17 02:32:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182823006/1
5 years, 6 months ago (2015-06-17 02:32:55 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/100098)
5 years, 6 months ago (2015-06-17 03:56:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182823006/1
5 years, 6 months ago (2015-06-17 04:17:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/100145)
5 years, 6 months ago (2015-06-17 06:01:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182823006/1
5 years, 6 months ago (2015-06-17 06:17:41 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/100184)
5 years, 6 months ago (2015-06-17 08:45:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182823006/1
5 years, 6 months ago (2015-06-17 20:53:50 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 21:34:20 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e44c8b2620991646c8e5fb06e5ab8f61a395b928 Cr-Commit-Position: refs/heads/master@{#334926}
5 years, 6 months ago (2015-06-17 21:35:12 UTC) #18
Tom Sepez
5 years, 4 months ago (2015-08-14 22:30:40 UTC) #19
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698