Roll libjingle 257:260.

Roll libjingle 257:262.

BUG=webrtc 850,940 crbug 165326

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177090

[Ronghua Wu (Left Chromium), 2013-01-11 00:52:32]

https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
File content/renderer/media/rtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
content/renderer/media/rtc_peer_connection_handler.cc:66: return
WebKit::WebRTCPeerConnectionHandlerClient::ReadyStateNew;
Per, what should we return here since the
WebRTCPeerConnectionHandlerClient::ReadyStateStable is not defined yet.

[perkj_chrome, 2013-01-11 07:57:01]

Please see suggestion for fixing the unittest error below. I think the most
important is to land the DEPS roll and I can update my patch
https://codereview.chromium.org/11801010/ to the new states ASAP after that.

lgtm if you get the unit test to not fail.

https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
File content/renderer/media/rtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
content/renderer/media/rtc_peer_connection_handler.cc:66: return
WebKit::WebRTCPeerConnectionHandlerClient::ReadyStateNew;
Please check later today if Tommy Ws cl for adding
WebRTCPeerConnectionHandlerClient::SignalingState is in. If so use
SignalingState instead of ReadyState. 

Please also rename the function to GetWebKitSignalingState.

If it's not in - just return ReadyStateActive and let me and Tommy now so we can
update as soon as his patch is in.

Thanks for doing this.
On 2013/01/11 00:52:32, Ronghua Wu wrote:
> Per, what should we return here since the
> WebRTCPeerConnectionHandlerClient::ReadyStateStable is not defined yet.

https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
File content/renderer/media/rtc_peer_connection_handler_unittest.cc (right):

https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
content/renderer/media/rtc_peer_connection_handler_unittest.cc:368: // Ready
states.
Signaling states

[perkj_chrome, 2013-01-11 08:38:48]

I just spoke to Tommy W. -
WebKit::WebRTCPeerConnectionHandlerClient::SignalingState will not land today so
use ReadyStateActive for now.

On 2013/01/11 07:57:01, perkj wrote:
> Please see suggestion for fixing the unittest error below. I think the most
> important is to land the DEPS roll and I can update my patch
> https://codereview.chromium.org/11801010/ to the new states ASAP after that.
> 
> lgtm if you get the unit test to not fail.
> 
>
https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
> File content/renderer/media/rtc_peer_connection_handler.cc (right):
> 
>
https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
> content/renderer/media/rtc_peer_connection_handler.cc:66: return
> WebKit::WebRTCPeerConnectionHandlerClient::ReadyStateNew;
> Please check later today if Tommy Ws cl for adding
> WebRTCPeerConnectionHandlerClient::SignalingState is in. If so use
> SignalingState instead of ReadyState. 
> 
> Please also rename the function to GetWebKitSignalingState.
> 
> If it's not in - just return ReadyStateActive and let me and Tommy now so we
can
> update as soon as his patch is in.
> 
> Thanks for doing this.
> On 2013/01/11 00:52:32, Ronghua Wu wrote:
> > Per, what should we return here since the
> > WebRTCPeerConnectionHandlerClient::ReadyStateStable is not defined yet.
> 
>
https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
> File content/renderer/media/rtc_peer_connection_handler_unittest.cc (right):
> 
>
https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
> content/renderer/media/rtc_peer_connection_handler_unittest.cc:368: // Ready
> states.
> Signaling states

[Ronghua Wu (Left Chromium), 2013-01-11 19:03:01]

https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
File content/renderer/media/rtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
content/renderer/media/rtc_peer_connection_handler.cc:66: return
WebKit::WebRTCPeerConnectionHandlerClient::ReadyStateNew;
On 2013/01/11 07:57:01, perkj wrote:
> Please check later today if Tommy Ws cl for adding
> WebRTCPeerConnectionHandlerClient::SignalingState is in. If so use
> SignalingState instead of ReadyState. 
> 
> Please also rename the function to GetWebKitSignalingState.
> 
> If it's not in - just return ReadyStateActive and let me and Tommy now so we
can
> update as soon as his patch is in.
> 
> Thanks for doing this.
> On 2013/01/11 00:52:32, Ronghua Wu wrote:
> > Per, what should we return here since the
> > WebRTCPeerConnectionHandlerClient::ReadyStateStable is not defined yet.
> 

Done.

https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
File content/renderer/media/rtc_peer_connection_handler_unittest.cc (right):

https://codereview.chromium.org/11828060/diff/1/content/renderer/media/rtc_pe...
content/renderer/media/rtc_peer_connection_handler_unittest.cc:368: // Ready
states.
On 2013/01/11 07:57:01, perkj wrote:
> Signaling states

Done.

[wjia(left Chromium), 2013-01-11 19:06:45]

lgtm

[Sergey Ulanov, 2013-01-11 19:15:37]

lgtm

[commit-bot: I haz the power, 2013-01-11 20:27:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/11828060/24001

[commit-bot: I haz the power, 2013-01-11 21:01:48]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-11 22:13:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/11828060/24001

[commit-bot: I haz the power, 2013-01-11 22:34:45]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-12 00:33:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/11828060/33002

[commit-bot: I haz the power, 2013-01-12 01:45:49]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-12 19:42:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/11828060/28004

[commit-bot: I haz the power, 2013-01-12 19:59:49]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-14 23:03:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/11828060/34008

[Ronghua Wu (Left Chromium), 2013-01-15 01:35:23]

Justin,

As discussed, I will hold this cl until your signal.

[commit-bot: I haz the power, 2013-01-16 01:46:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/11828060/45001

[commit-bot: I haz the power, 2013-01-16 05:31:31]

Change committed as 177090