Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: chrome/browser/resources/web_dev_style/js_checker.py

Issue 11828036: First cut at UI for saving net_logs data into a temporary file on (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for Chromium JS resources. 5 """Presubmit script for Chromium JS resources.
6 6
7 See chrome/browser/resources/PRESUBMIT.py 7 See chrome/browser/resources/PRESUBMIT.py
8 """ 8 """
9 9
10 class JSChecker(object): 10 class JSChecker(object):
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 (if it's in a directory where we haven't done that yet). 81 (if it's in a directory where we haven't done that yet).
82 """ 82 """
83 # TODO(tbreisacher): Once we've cleaned up the style nits in all of 83 # TODO(tbreisacher): Once we've cleaned up the style nits in all of
84 # resources/ we can get rid of this function. 84 # resources/ we can get rid of this function.
85 path = self.input_api.os_path 85 path = self.input_api.os_path
86 resources = self.input_api.PresubmitLocalPath() 86 resources = self.input_api.PresubmitLocalPath()
87 dirs = ( 87 dirs = (
88 path.join(resources, 'extensions'), 88 path.join(resources, 'extensions'),
89 path.join(resources, 'help'), 89 path.join(resources, 'help'),
90 path.join(resources, 'history'), 90 path.join(resources, 'history'),
91 path.join(resources, 'net_export'),
91 path.join(resources, 'net_internals'), 92 path.join(resources, 'net_internals'),
92 path.join(resources, 'network_action_predictor'), 93 path.join(resources, 'network_action_predictor'),
93 path.join(resources, 'ntp4'), 94 path.join(resources, 'ntp4'),
94 path.join(resources, 'options'), 95 path.join(resources, 'options'),
95 path.join(resources, 'print_preview'), 96 path.join(resources, 'print_preview'),
96 path.join(resources, 'profiler'), 97 path.join(resources, 'profiler'),
97 path.join(resources, 'sync_promo'), 98 path.join(resources, 'sync_promo'),
98 path.join(resources, 'tracing'), 99 path.join(resources, 'tracing'),
99 path.join(resources, 'uber'), 100 path.join(resources, 'uber'),
100 ) 101 )
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 222
222 if results: 223 if results:
223 results.append(self.output_api.PresubmitNotifyResult( 224 results.append(self.output_api.PresubmitNotifyResult(
224 'See the JavaScript style guide at ' 225 'See the JavaScript style guide at '
225 'http://www.chromium.org/developers/web-development-style-guide' 226 'http://www.chromium.org/developers/web-development-style-guide'
226 '#TOC-JavaScript and if you have any feedback about the JavaScript ' 227 '#TOC-JavaScript and if you have any feedback about the JavaScript '
227 'PRESUBMIT check, contact tbreisacher@chromium.org or ' 228 'PRESUBMIT check, contact tbreisacher@chromium.org or '
228 'dbeam@chromium.org')) 229 'dbeam@chromium.org'))
229 230
230 return results 231 return results
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698