chrome/browser/resources/net_export/net_export.html - Issue 11828036: First cut at UI for saving net_logs data into a temporary file on

Side by Side Diff: chrome/browser/resources/net_export/net_export.html

Issue 11828036: First cut at UI for saving net_logs data into a temporary file on (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/net/net_log_temp_file.cc ('K') | « chrome/browser/net/net_log_temp_file.cc ('k') | chrome/browser/resources/net_export/net_export.js » ('j') | chrome/browser/resources/net_export/net_export.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <head>

	4 <meta charset="utf-8">

	5 <script src="chrome://resources/js/util.js"></script>

	6 <script src="chrome://resources/js/cr.js"></script>

	7 <script src="chrome://net-export/net_export.js"></script>

	8

	9 <style>

	10

	11 body {

	12 font-family: sans-serif;

	13 font-size: 80%;

	14 }

	15

	16 <style>
	mmenke 2013/01/11 18:31:12 This tag isn't needed, since you have one just abo This tag isn't needed, since you have one just above. ramant (doing other things) 2013/01/12 04:34:04 Done. Show quoted text On 2013/01/11 18:31:12, Matt Menke wrote: > This tag isn't needed, since you have one just above. Done.
	17

	18 #export-view-start-data {
	mmenke 2013/01/11 18:31:12 Rather than having three rules, can just use one f Rather than having three rules, can just use one for all buttons: button { ... } ramant (doing other things) 2013/01/12 04:34:04 Done. Show quoted text On 2013/01/11 18:31:12, Matt Menke wrote: > Rather than having three rules, can just use one for all buttons: > > button { > ... > } Done.
	19 font-size: 100%;

	20 font-weight: bold;

	21 }

	22

	23 #export-view-stop-data {

	24 font-size: 100%;

	25 font-weight: bold;

	26 }

	27

	28 #export-view-send-data {

	29 font-size: 100%;

	30 font-weight: bold;

	31 }

	32

	33 </style>

	34 </head>

	35 <body>

	36 <h2>NetLog Export</h2>

	37 <div style="margin: 8px">

	38 <div>

	39 <button id=export-view-start-data>Start Saving (after deleting old data)
	mmenke 2013/01/11 18:31:12 Suggest just "Start Logging to Disk" "Stop Logging Suggest just "Start Logging to Disk" "Stop Logging" and "Email Log". I think "logging" lets us use much better text at the bottom. Can put "Deletes old log" in red after the button. ramant (doing other things) 2013/01/12 04:34:04 Done. Show quoted text On 2013/01/11 18:31:12, Matt Menke wrote: > Suggest just "Start Logging to Disk" "Stop Logging" and "Email Log". I think > "logging" lets us use much better text at the bottom. Can put "Deletes old log" > in red after the button. Done.
	40 </button>

	41 </div>

	42 <div>

	43 <button id=export-view-stop-data>Stop Saving Data</button>

	44 </div>

	45 <div>

	46 <button id=export-view-send-data>Send Data</button>

	47 </div>
	mmenke 2013/01/11 18:31:12 nit: Fix indent. nit: Fix indent. ramant (doing other things) 2013/01/12 04:34:04 Done. Show quoted text On 2013/01/11 18:31:12, Matt Menke wrote: > nit: Fix indent. Done.
	48 <pre id=export-view-file-path-text></pre>

	49

	50 <ul>

	51 <li><b>IMPORTANT</b>: First reproduce the problem while in

	52 saving mode. After stop saving data, finish sending the data before

	53 start saving.</li>
	mmenke 2013/01/11 18:31:12 I think "INSTRUCTIONS: Start logging, reproduce t I think "INSTRUCTIONS: Start logging, reproduce the problem, and then stop logging. Make sure to send the email before starting to log again. Otherwise, the log will be deleted." ramant (doing other things) 2013/01/12 04:34:04 Done. Show quoted text On 2013/01/11 18:31:12, Matt Menke wrote: > I think "INSTRUCTIONS: Start logging, reproduce the problem, and then stop > logging. Make sure to send the email before starting to log again. Otherwise, > the log will be deleted." Done.
	54 </ul>

	55 <p>

	56 For more information see:

	57 <a href="chrome://net-internals/help.html" target="_blank">

	58 How to get data for bug reports?

	59 </a>
	mmenke 2013/01/11 18:31:12 Does help.html contain anything useful beyond the Does help.html contain anything useful beyond the above instructions? Maybe just say "Logs can be loaded in net-internals of desktop Chrome"? (With a link) ramant (doing other things) 2013/01/12 04:34:04 Done. Show quoted text On 2013/01/11 18:31:12, Matt Menke wrote: > Does help.html contain anything useful beyond the above instructions? Maybe > just say "Logs can be loaded in net-internals of desktop Chrome"? (With a link) Done.
	60 </p>

	61 </div>

	62 </body>

	63 </html>

OLD	NEW