Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py

Issue 11828009: Ensure nacl_integration does not report UMA stats. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import os.path 6 import os.path
7 import re 7 import re
8 import shutil 8 import shutil
9 import sys 9 import sys
10 import tempfile 10 import tempfile
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 266
267 def MakeCmd(self, url, port): 267 def MakeCmd(self, url, port):
268 cmd = [self.binary, 268 cmd = [self.binary,
269 '--disable-web-resources', 269 '--disable-web-resources',
270 '--disable-preconnect', 270 '--disable-preconnect',
271 '--no-first-run', 271 '--no-first-run',
272 '--no-default-browser-check', 272 '--no-default-browser-check',
273 '--enable-logging', 273 '--enable-logging',
274 '--log-level=1', 274 '--log-level=1',
275 '--safebrowsing-disable-auto-update', 275 '--safebrowsing-disable-auto-update',
276 # Suppress metrics reporting.
Mark Seaborn 2013/01/09 00:20:36 Add more explanation? Maybe "Suppress metrics (UM
277 '--metrics-recording-only',
276 # Chrome explicitly blacklists some ports as "unsafe" because 278 # Chrome explicitly blacklists some ports as "unsafe" because
277 # certain protocols use them. Chrome gives an error like this: 279 # certain protocols use them. Chrome gives an error like this:
278 # Error 312 (net::ERR_UNSAFE_PORT): Unknown error 280 # Error 312 (net::ERR_UNSAFE_PORT): Unknown error
279 # Unfortunately, the browser tester can randomly choose a 281 # Unfortunately, the browser tester can randomly choose a
280 # blacklisted port. To work around this, the tester whitelists 282 # blacklisted port. To work around this, the tester whitelists
281 # whatever port it is using. 283 # whatever port it is using.
282 '--explicitly-allowed-ports=%d' % port, 284 '--explicitly-allowed-ports=%d' % port,
283 '--user-data-dir=%s' % self.profile] 285 '--user-data-dir=%s' % self.profile]
284 # Log network requests to assist debugging. 286 # Log network requests to assist debugging.
285 cmd.append('--log-net-log=%s' % self.NetLogName()) 287 cmd.append('--log-net-log=%s' % self.NetLogName())
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 '--trace-children=yes', 322 '--trace-children=yes',
321 '--nacl-file=%s' % (self.options.files[0],), 323 '--nacl-file=%s' % (self.options.files[0],),
322 '--ignore=../tools/valgrind/tsan/ignores.txt', 324 '--ignore=../tools/valgrind/tsan/ignores.txt',
323 '--suppressions=../tools/valgrind/tsan/suppressions.txt', 325 '--suppressions=../tools/valgrind/tsan/suppressions.txt',
324 '--log-file=%s/log.%%p' % (self.tool_log_dir,)] + cmd 326 '--log-file=%s/log.%%p' % (self.tool_log_dir,)] + cmd
325 elif self.options.tool != None: 327 elif self.options.tool != None:
326 raise LaunchFailure('Invalid tool name "%s"' % (self.options.tool,)) 328 raise LaunchFailure('Invalid tool name "%s"' % (self.options.tool,))
327 cmd.extend(self.options.browser_flags) 329 cmd.extend(self.options.browser_flags)
328 cmd.append(url) 330 cmd.append(url)
329 return cmd 331 return cmd
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698