Extend big-disjunction optimization to case-independent regexps

Extend big-disjunction optimization to case-independent regexps

R=yangguo@chromium.org
BUG=chromium:482998
LOG=n

Committed: https://crrev.com/d2135603bcf462e15a1284d8ed969f6692610dda
Cr-Commit-Position: refs/heads/master@{#29264}

[Erik Corry Chromium.org, 2015-06-16 20:17:28]

https://codereview.chromium.org/1182783009/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):

https://codereview.chromium.org/1182783009/diff/1/src/jsregexp.cc#newcode4897
src/jsregexp.cc:4897: alternatives->StableSort(compare_closure, first_atom, i -
first_atom);
Closures have a different type to function pointers. That's why the sort
routines had to be genericized.

[Erik Corry Chromium.org, 2015-06-16 21:59:30]

The CQ bit was checked by erikcorry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-16 21:59:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182783009/20001

[Erik Corry Chromium.org, 2015-06-17 07:21:13]

https://codereview.chromium.org/1182783009/diff/40001/test/mjsunit/regexp-sor...
File test/mjsunit/regexp-sort.js (right):

https://codereview.chromium.org/1182783009/diff/40001/test/mjsunit/regexp-sor...
test/mjsunit/regexp-sort.js:33: Test(String.fromCharCode(0xb5),
String.fromCharCode(0x3bc));
Firefox fails this.  I think we are doing it right.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1175416

[Yang, 2015-06-18 14:19:41]

On 2015/06/17 07:21:13, Erik Corry Chromium.org wrote:
>
https://codereview.chromium.org/1182783009/diff/40001/test/mjsunit/regexp-sor...
> File test/mjsunit/regexp-sort.js (right):
> 
>
https://codereview.chromium.org/1182783009/diff/40001/test/mjsunit/regexp-sor...
> test/mjsunit/regexp-sort.js:33: Test(String.fromCharCode(0xb5),
> String.fromCharCode(0x3bc));
> Firefox fails this.  I think we are doing it right.
> See https://bugzilla.mozilla.org/show_bug.cgi?id=1175416

... I'm half way through, will continue tomorrow.

[Yang, 2015-06-19 10:25:20]

lgtm.

https://codereview.chromium.org/1182783009/diff/60001/test/mjsunit/regexp-sor...
File test/mjsunit/regexp-sort.js (right):

https://codereview.chromium.org/1182783009/diff/60001/test/mjsunit/regexp-sor...
test/mjsunit/regexp-sort.js:6: assertEquals(lower + "x", new RegExp(upper + "x|"
+ lower + "|" + lower + "cat", "i").exec(lower + "x") + "");
80 char limit

[Erik Corry Chromium.org, 2015-06-24 17:24:52]

The CQ bit was checked by erikcorry@chromium.org

[Erik Corry Chromium.org, 2015-06-24 17:24:52]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1182783009/#ps80001
(title: "Fix 80 columns in test")

[commit-bot: I haz the power, 2015-06-24 17:25:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182783009/80001

[commit-bot: I haz the power, 2015-06-24 18:17:41]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-24 18:17:52]

Patchset 5 (id:??) landed as
https://crrev.com/d2135603bcf462e15a1284d8ed969f6692610dda
Cr-Commit-Position: refs/heads/master@{#29264}

[Michael Achenbach, 2015-06-24 19:03:40]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1204013003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Test times out now on msan:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s....