Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182783008: Add an option to not prune the Android AX tree, to preserve more style info. (Closed)

Created:
5 years, 6 months ago by dmazzoni
Modified:
5 years, 6 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@style_info_sgurun
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an option to not prune the Android AX tree, to preserve more style info. BUG=501039 Committed: https://crrev.com/38de562f2a8dd70c04e5a2d955e1784f281a1c3d Cr-Commit-Position: refs/heads/master@{#334740}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Un-disable tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -26 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 1 2 5 chunks +12 lines, -12 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 1 chunk +14 lines, -10 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.h View 2 chunks +15 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dmazzoni
Depends on: https://codereview.chromium.org/1181883003/
5 years, 6 months ago (2015-06-16 19:29:43 UTC) #2
sgurun-gerrit only
On 2015/06/16 19:29:43, dmazzoni wrote: > Depends on: > https://codereview.chromium.org/1181883003/ lgtm
5 years, 6 months ago (2015-06-16 20:28:34 UTC) #3
sgurun-gerrit only
https://codereview.chromium.org/1182783008/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java (right): https://codereview.chromium.org/1182783008/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java#newcode667 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java:667: assertTrue(child2child.bold); sorry, so strong implies bold and not a ...
5 years, 6 months ago (2015-06-16 20:28:43 UTC) #4
dmazzoni
Rebased and ready to land. +tedchoc for content/browser/web_contents
5 years, 6 months ago (2015-06-16 21:34:20 UTC) #6
Ted C
lgtm
5 years, 6 months ago (2015-06-16 23:00:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182783008/40001
5 years, 6 months ago (2015-06-16 23:08:44 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-16 23:14:50 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 23:15:39 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/38de562f2a8dd70c04e5a2d955e1784f281a1c3d
Cr-Commit-Position: refs/heads/master@{#334740}

Powered by Google App Engine
This is Rietveld 408576698