Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Side by Side Diff: chrome/BUILD.gn

Issue 1182783006: Revert of Fix some build symbol configuration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/linux/dump_app_syms.py ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//build/config/locales.gni") 7 import("//build/config/locales.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 import("//chrome/chrome_repack_locales.gni") 9 import("//chrome/chrome_repack_locales.gni")
10 import("//chrome/version.gni") 10 import("//chrome/version.gni")
(...skipping 790 matching lines...) Expand 10 before | Expand all | Expand 10 after
801 ] 801 ]
802 802
803 args = [ 803 args = [
804 rebase_path(infile, root_build_dir), 804 rebase_path(infile, root_build_dir),
805 rebase_path(outfile, root_build_dir), 805 rebase_path(outfile, root_build_dir),
806 "-e s/@@NAME@@/$name/", 806 "-e s/@@NAME@@/$name/",
807 "-e s/@@FILENAME@@/$filename/", 807 "-e s/@@FILENAME@@/$filename/",
808 "-e s/@@CONFDIR@@/$confdir/", 808 "-e s/@@CONFDIR@@/$confdir/",
809 ] 809 ]
810 } 810 }
811
812 action("linux_symbols") {
813 script = "//build/linux/dump_app_syms"
814
815 dump_syms_label = "//breakpad:dump_syms($host_toolchain)"
816 dump_syms_binary =
817 get_label_info(dump_syms_label, "root_out_dir") + "/" + "dump_syms"
818
819 chrome_binary = "$root_out_dir/chrome"
820 if (current_cpu == "x86") {
821 # Use "ia32" instead of "x86" for GYP compat.
822 symbol_file = "$root_out_dir/chrome.breakpad.ia32"
823 } else {
824 symbol_file = "$root_out_dir/chrome.breakpad.$current_cpu"
825 }
826
827 inputs = [
828 chrome_binary,
829 dump_syms_binary,
830 ]
831 outputs = [
832 symbol_file,
833 ]
834
835 args = [
836 rebase_path(dump_syms_binary, root_build_dir),
837 "0", # TODO(GYP) This is linux_strip_binary if it is needed.
838 rebase_path(chrome_binary, root_build_dir),
839 rebase_path(symbol_file, root_build_dir),
840 ]
841
842 deps = [
843 ":chrome",
844 dump_syms_label,
845 ]
846 }
847 } 811 }
OLDNEW
« no previous file with comments | « build/linux/dump_app_syms.py ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698