Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1895)

Issue 1182783006: Revert of Fix some build symbol configuration. (Closed)

Created:
5 years, 6 months ago by Lei Zhang
Modified:
5 years, 6 months ago
Reviewers:
Nico, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix some build symbol configuration. (patchset #3 id:40001 of https://codereview.chromium.org/1179393004/) Reason for revert: Broke the Linux GN Clobber bot: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/1271/steps/compile/logs/stdio ninja: error: '../../build/linux/dump_app_syms', needed by 'obj/chrome/linux_symbols.inputdeps.stamp', missing and no known rule to make it Original issue's description: > Fix some build symbol configuration. > > Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant. > > Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission. > > Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team. > > BUG= > > Committed: https://crrev.com/950889c01dd934acf28bce29ea6db75610a8c441 > Cr-Commit-Position: refs/heads/master@{#334510} TBR=thakis@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/520e8fd6084a0b3f1ec1011273730c4c6e392d09 Cr-Commit-Position: refs/heads/master@{#334522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -72 lines) Patch
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A build/linux/dump_app_syms View 1 chunk +36 lines, -0 lines 0 comments Download
D build/linux/dump_app_syms.py View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/BUILD.gn View 1 chunk +1 line, -37 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of Fix some build symbol configuration.
5 years, 6 months ago (2015-06-16 01:09:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182783006/1
5 years, 6 months ago (2015-06-16 01:10:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 01:12:04 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 01:12:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/520e8fd6084a0b3f1ec1011273730c4c6e392d09
Cr-Commit-Position: refs/heads/master@{#334522}

Powered by Google App Engine
This is Rietveld 408576698