Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182743002: Animate checkboxes (Closed)

Created:
5 years, 6 months ago by jackson
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Animate checkboxes. I based it on the dialer app. Could probably use more improvement, but I think this is an improvement on what we are doing currently. R=abarth@chromium.org, abarth Committed: https://chromium.googlesource.com/external/mojo/+/e63070cdc9f723dab616cfdb6d6adf2b0debbc1d

Patch Set 1 : WIP initial implementation #

Patch Set 2 : transition to purple more gradually #

Total comments: 5

Patch Set 3 : CR feedback from abarth #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -25 lines) Patch
M sky/sdk/lib/framework/widgets/checkbox.dart View 1 2 2 chunks +86 lines, -23 lines 0 comments Download
M sky/sdk/lib/framework/widgets/wrappers.dart View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jackson
5 years, 6 months ago (2015-06-12 07:08:44 UTC) #3
abarth-chromium
lgtm https://codereview.chromium.org/1182743002/diff/60001/sky/sdk/lib/framework/widgets/checkbox.dart File sky/sdk/lib/framework/widgets/checkbox.dart (right): https://codereview.chromium.org/1182743002/diff/60001/sky/sdk/lib/framework/widgets/checkbox.dart#newcode13 sky/sdk/lib/framework/widgets/checkbox.dart:13: import 'animated_component.dart'; Please sort these alphabetically. https://codereview.chromium.org/1182743002/diff/60001/sky/sdk/lib/framework/widgets/checkbox.dart#newcode33 sky/sdk/lib/framework/widgets/checkbox.dart:33: ...
5 years, 6 months ago (2015-06-12 13:35:14 UTC) #4
jackson
https://codereview.chromium.org/1182743002/diff/60001/sky/sdk/lib/framework/widgets/checkbox.dart File sky/sdk/lib/framework/widgets/checkbox.dart (right): https://codereview.chromium.org/1182743002/diff/60001/sky/sdk/lib/framework/widgets/checkbox.dart#newcode116 sky/sdk/lib/framework/widgets/checkbox.dart:116: => new Point(p1.x * (1.0 - t) + p2.x ...
5 years, 6 months ago (2015-06-12 19:45:03 UTC) #5
jackson
5 years, 6 months ago (2015-06-12 19:45:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:100001) manually as
e63070cdc9f723dab616cfdb6d6adf2b0debbc1d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698