Set the active input method correctly when EnableLayouts is called.

Set the active input method correctly when EnableLayouts is called.

ChangeInputMethodInternal called by EnableLayouts checks if component_extension_ime_manager_ is initialized or not.  When it is not initialized, active_input_method is not updated even if the new input method is a keyboard layout.

This patch checks if the new input method is a keyboard layout or not too.

BUG=329061
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242075

[Seigo Nonaka, 2013-12-19 03:41:12]

lgtm with one comments.

https://codereview.chromium.org/118273002/diff/1/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/118273002/diff/1/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:329: if
(current_input_method_.id() != input_method_id_to_switch) {
How about remove this condition?

This condition can be false? (probably yes in past, but now I think no).

And seems safe to execute this statement even current and next input method id
is equal.

[Hiro Komatsu, 2013-12-19 04:32:04]

https://codereview.chromium.org/118273002/diff/1/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/118273002/diff/1/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:329: if
(current_input_method_.id() != input_method_id_to_switch) {
On 2013/12/19 03:41:12, Seigo Nonaka wrote:
> How about remove this condition?
> 
> This condition can be false? (probably yes in past, but now I think no).
> 
> And seems safe to execute this statement even current and next input method id
> is equal.

This can be false when the sanity check from line:283 is performed.  In that
case line:294 will be true too though.

I will remove the condition.  Please let me know if you get additional concerns.

[Hiro Komatsu, 2013-12-20 10:06:05]

On 2013/12/19 04:32:04, Hiro Komatsu (OOO Dec19 - 25) wrote:
>
https://codereview.chromium.org/118273002/diff/1/chrome/browser/chromeos/inpu...
> File chrome/browser/chromeos/input_method/input_method_manager_impl.cc
(right):
> 
>
https://codereview.chromium.org/118273002/diff/1/chrome/browser/chromeos/inpu...
> chrome/browser/chromeos/input_method/input_method_manager_impl.cc:329: if
> (current_input_method_.id() != input_method_id_to_switch) {
> On 2013/12/19 03:41:12, Seigo Nonaka wrote:
> > How about remove this condition?
> > 
> > This condition can be false? (probably yes in past, but now I think no).
> > 
> > And seems safe to execute this statement even current and next input method
id
> > is equal.
> 
> This can be false when the sanity check from line:283 is performed.  In that
> case line:294 will be true too though.
> 
> I will remove the condition.  Please let me know if you get additional
concerns.

When I simply  delete the condition, some unittests failed.  Since this patch
will be merged to M33, due to avoid regressions, let me commit this patch as-is.
Then I will try to delete the condition again.

[commit-bot: I haz the power, 2013-12-20 10:07:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/komatsu@chromium.org/118273002/1

[commit-bot: I haz the power, 2013-12-20 12:34:12]

Change committed as 242075