Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11827045: google_apis: Add set_offline() to FakeDriveService (Closed)

Created:
7 years, 11 months ago by satorux1
Modified:
7 years, 11 months ago
Reviewers:
kinaba
CC:
chromium-reviews, achuith+watch_chromium.org
Visibility:
Public.

Description

google_apis: Add set_offline() to FakeDriveService This can be used to simulate the offline state. BUG=162350 TEST=none; no changes in production code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176040

Patch Set 1 : #

Total comments: 10

Patch Set 2 : address comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -1 line) Patch
M chrome/browser/google_apis/fake_drive_service.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/fake_drive_service.cc View 1 13 chunks +96 lines, -1 line 0 comments Download
M chrome/browser/google_apis/fake_drive_service_unittest.cc View 11 chunks +204 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
7 years, 11 months ago (2013-01-10 04:28:15 UTC) #1
kinaba
https://codereview.chromium.org/11827045/diff/2001/chrome/browser/google_apis/fake_drive_service.cc File chrome/browser/google_apis/fake_drive_service.cc (right): https://codereview.chromium.org/11827045/diff/2001/chrome/browser/google_apis/fake_drive_service.cc#newcode218 chrome/browser/google_apis/fake_drive_service.cc:218: scoped_ptr<base::Value> null; not used. https://codereview.chromium.org/11827045/diff/2001/chrome/browser/google_apis/fake_drive_service.cc#newcode277 chrome/browser/google_apis/fake_drive_service.cc:277: scoped_ptr<base::Value> null; ditto. ...
7 years, 11 months ago (2013-01-10 04:33:54 UTC) #2
satorux1
https://codereview.chromium.org/11827045/diff/2001/chrome/browser/google_apis/fake_drive_service.cc File chrome/browser/google_apis/fake_drive_service.cc (right): https://codereview.chromium.org/11827045/diff/2001/chrome/browser/google_apis/fake_drive_service.cc#newcode218 chrome/browser/google_apis/fake_drive_service.cc:218: scoped_ptr<base::Value> null; On 2013/01/10 04:33:54, kinaba wrote: > not ...
7 years, 11 months ago (2013-01-10 04:41:33 UTC) #3
kinaba
7 years, 11 months ago (2013-01-10 04:44:39 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698