Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: content/renderer/media/renderer_webaudiodevice_impl.cc

Issue 11827040: Update RendererWebKitPlatformSupportImpl::createAudioDevice() to handle |input_channels| (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/renderer_webaudiodevice_impl.cc
===================================================================
--- content/renderer/media/renderer_webaudiodevice_impl.cc (revision 175940)
+++ content/renderer/media/renderer_webaudiodevice_impl.cc (working copy)
@@ -22,8 +22,10 @@
RendererWebAudioDeviceImpl::RendererWebAudioDeviceImpl(
const media::AudioParameters& params,
+ unsigned input_channels,
WebAudioDevice::RenderCallback* callback)
: params_(params),
+ input_channels_(input_channels),
client_callback_(callback) {
DCHECK(client_callback_);
}
@@ -39,18 +41,8 @@
return; // Already started.
output_device_ = AudioDeviceFactory::NewOutputDevice();
+ output_device_->InitializeIO(params_, input_channels_, this);
- // TODO(crogers): remove once we properly handle input device selection.
- // https://code.google.com/p/chromium/issues/detail?id=147327
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableWebAudioInput)) {
- // TODO(crogers): support more than hard-coded stereo:
- // https://code.google.com/p/chromium/issues/detail?id=147326
- output_device_->InitializeIO(params_, 2, this);
- } else {
- output_device_->Initialize(params_, this);
- }
-
// Assumption: This method is being invoked within a V8 call stack. CHECKs
// will fail in the call to frameForCurrentContext() otherwise.
//

Powered by Google App Engine
This is Rietveld 408576698