Update RendererWebKitPlatformSupportImpl::createAudioDevice() to handle |input_channels|

Update RendererWebKitPlatformSupportImpl::createAudioDevice() to handle |input_channels|

This is a first step towards weaning ourselves off the "Web Audio Input" enable flag.
It also provides a more efficient way for WebKit to tell us if it actually needs
live/local audio input (or not).

Please see WebKit API change for details:
https://bugs.webkit.org/show_bug.cgi?id=106490

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176552

[Chris Rogers, 2013-01-10 00:27:41]

dalecurtis: for audio-related code
jamesr: for content OWNERS

[DaleCurtis, 2013-01-10 01:11:41]

You'll need to rebase this:
http://src.chromium.org/viewvc/chrome?view=rev&revision=175948

[Chris Rogers, 2013-01-10 01:45:54]

On 2013/01/10 01:11:41, DaleCurtis wrote:
> You'll need to rebase this:
> http://src.chromium.org/viewvc/chrome?view=rev&revision=175948

Andrew's CL looks great :) But I don't think it touches any of the same files.

I'm still waiting for my WebKit-side patch to land, and for DEPS to roll before
this one can land, but appreciate review...

[DaleCurtis, 2013-01-10 02:09:49]

Doh. I misread the files. My bad.

lgtm % style question that jamesr can probably answer.

https://codereview.chromium.org/11827040/diff/4001/content/renderer/media/ren...
File content/renderer/media/renderer_webaudiodevice_impl.h (right):

https://codereview.chromium.org/11827040/diff/4001/content/renderer/media/ren...
content/renderer/media/renderer_webaudiodevice_impl.h:24: unsigned
input_channels,
Hmm, should this be size_t? I'm not sure at which point you should start using
chromium conventions here.

[jamesr, 2013-01-10 03:37:15]

https://codereview.chromium.org/11827040/diff/4001/content/renderer/media/ren...
File content/renderer/media/renderer_webaudiodevice_impl.h (right):

https://codereview.chromium.org/11827040/diff/4001/content/renderer/media/ren...
content/renderer/media/renderer_webaudiodevice_impl.h:24: unsigned
input_channels,
On 2013/01/10 02:09:49, DaleCurtis wrote:
> Hmm, should this be size_t? I'm not sure at which point you should start using
> chromium conventions here.

This is chromium code, so it should follow the chromium style conventions.  For
this, chromium style guide defers to the google style guide which says this:

Of the built-in C++ integer types, the only one used is int. If a program needs
a variable of a different size, use a precise-width integer type from
<stdint.h>, such as int16_t.

...

So, document that a variable is non-negative using assertions. Don't use an
unsigned type.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Integer_Types

so this should be 'int'

[Chris Rogers, 2013-01-11 00:00:20]

changed |input_channels| to be int

Assuming this is ok, this can land once we roll past WebKit r139262

[jamesr, 2013-01-11 21:48:39]

lgtm

[DaleCurtis, 2013-01-11 22:42:31]

lgtm

[commit-bot: I haz the power, 2013-01-11 22:48:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/crogers@google.com/11827040/10002

[commit-bot: I haz the power, 2013-01-12 17:05:47]

Change committed as 176552