Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1182703003: [V8] Fixed infinite loop in Debug::PrepareStep (Closed)

Created:
5 years, 6 months ago by kozy
Modified:
5 years, 6 months ago
Reviewers:
Yang, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[V8] Fixed infinite loop in Debug::PrepareStep frame->GetExpression always returns the same function. We should iterate through expression stack when we use Function.call.apply for finding actual target. LOG=N BUG=chromium:499479 R=yurys@chromium.org,yangguo@chromium.org Committed: https://crrev.com/8e1c3a75b0acfed5baf79d120a26b263a56fcc28 Cr-Commit-Position: refs/heads/master@{#29048}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M src/debug.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M test/cctest/test-debug.cc View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
kozy
Yury, please take a look.
5 years, 6 months ago (2015-06-15 16:32:17 UTC) #1
yurys
lgtm https://codereview.chromium.org/1182703003/diff/1/test/cctest/test-debug.cc File test/cctest/test-debug.cc (right): https://codereview.chromium.org/1182703003/diff/1/test/cctest/test-debug.cc#newcode3839 test/cctest/test-debug.cc:3839: " Function.call.apply(bar);" Can you add one more test ...
5 years, 6 months ago (2015-06-16 10:37:15 UTC) #2
Yang
On 2015/06/16 10:37:15, yurys wrote: > lgtm > > https://codereview.chromium.org/1182703003/diff/1/test/cctest/test-debug.cc > File test/cctest/test-debug.cc (right): > ...
5 years, 6 months ago (2015-06-16 10:49:01 UTC) #3
kozy
Yang, please take a look. https://codereview.chromium.org/1182703003/diff/1/test/cctest/test-debug.cc File test/cctest/test-debug.cc (right): https://codereview.chromium.org/1182703003/diff/1/test/cctest/test-debug.cc#newcode3839 test/cctest/test-debug.cc:3839: " Function.call.apply(bar);" On 2015/06/16 ...
5 years, 6 months ago (2015-06-16 10:49:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182703003/20001
5 years, 6 months ago (2015-06-16 10:51:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 11:09:54 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 11:10:15 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e1c3a75b0acfed5baf79d120a26b263a56fcc28
Cr-Commit-Position: refs/heads/master@{#29048}

Powered by Google App Engine
This is Rietveld 408576698