Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: Source/platform/geometry/FloatPolygonTest.cpp

Issue 1182703002: Fix unit test style in Source/platform/, part 1. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/geometry/FloatPolygonTest.cpp
diff --git a/Source/platform/geometry/FloatPolygonTest.cpp b/Source/platform/geometry/FloatPolygonTest.cpp
index 47c4740a3f05c3a0c36d7e3f0a52fb91a2f47bc9..5e2f3d6c7e7f858038081a7b75f1dbacac1db5c7 100644
--- a/Source/platform/geometry/FloatPolygonTest.cpp
+++ b/Source/platform/geometry/FloatPolygonTest.cpp
@@ -28,7 +28,6 @@
*/
#include "config.h"
-
#include "platform/geometry/FloatPolygon.h"
#include <gtest/gtest.h>
@@ -52,18 +51,14 @@ private:
OwnPtr<FloatPolygon> m_polygon;
};
-} // namespace blink
-
namespace {
-using namespace blink;
-
-static bool compareEdgeIndex(const FloatPolygonEdge* edge1, const FloatPolygonEdge* edge2)
+bool compareEdgeIndex(const FloatPolygonEdge* edge1, const FloatPolygonEdge* edge2)
{
return edge1->edgeIndex() < edge2->edgeIndex();
}
-static Vector<const FloatPolygonEdge*> sortedOverlappingEdges(const FloatPolygon& polygon, float minY, float maxY)
+Vector<const FloatPolygonEdge*> sortedOverlappingEdges(const FloatPolygon& polygon, float minY, float maxY)
{
Vector<const FloatPolygonEdge*> result;
polygon.overlappingEdges(minY, maxY, result);
@@ -71,6 +66,8 @@ static Vector<const FloatPolygonEdge*> sortedOverlappingEdges(const FloatPolygon
return result;
}
+} // anonymous namespace
+
#define SIZEOF_ARRAY(p) (sizeof(p) / sizeof(p[0]))
/**
@@ -328,4 +325,4 @@ TEST(FloatPolygonTest, rectilinear)
EXPECT_FALSE(h.contains(FloatPoint(175, 225)));
}
-} // namespace
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698