Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2568)

Unified Diff: Source/platform/DecimalTest.cpp

Issue 1182703002: Fix unit test style in Source/platform/, part 1. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/DecimalTest.cpp
diff --git a/Source/platform/DecimalTest.cpp b/Source/platform/DecimalTest.cpp
index 38dd2c47322d1c0916f23490a63be0b42f1b84b0..43a79af4aad40c97eb2868c6b597faf70aa78e39 100644
--- a/Source/platform/DecimalTest.cpp
+++ b/Source/platform/DecimalTest.cpp
@@ -48,10 +48,6 @@ std::ostream& operator<<(std::ostream& os, const Decimal& decimal)
<< ")=" << decimal.toString().ascii().data();
}
-} // namespace blink
-
-using namespace blink;
-
// Simulate WebCore/html/StepRange
class DecimalStepRange {
public:
@@ -76,21 +72,21 @@ public:
class DecimalTest : public ::testing::Test {
protected:
- typedef Decimal::Sign Sign;
- protected: static const Sign Positive = Decimal::Positive;
- protected: static const Sign Negative = Decimal::Negative;
+ using Sign = Decimal::Sign;
+ static const Sign Positive = Decimal::Positive;
+ static const Sign Negative = Decimal::Negative;
Decimal encode(uint64_t coefficient, int exponent, Sign sign)
{
return Decimal(sign, exponent, coefficient);
}
- protected: Decimal fromString(const String& string)
+ Decimal fromString(const String& string)
{
return Decimal::fromString(string);
}
- protected: Decimal stepDown(const String& minimum, const String& maximum, const String& step, const String& valueString, int numberOfStepTimes)
+ Decimal stepDown(const String& minimum, const String& maximum, const String& step, const String& valueString, int numberOfStepTimes)
{
DecimalStepRange stepRange(fromString(minimum), fromString(maximum), fromString(step));
Decimal value = fromString(valueString);
@@ -101,7 +97,7 @@ protected:
return value;
}
- protected: Decimal stepUp(const String& minimum, const String& maximum, const String& step, const String& valueString, int numberOfStepTimes)
+ Decimal stepUp(const String& minimum, const String& maximum, const String& step, const String& valueString, int numberOfStepTimes)
{
DecimalStepRange stepRange(fromString(minimum), fromString(maximum), fromString(step));
Decimal value = fromString(valueString);
@@ -1123,3 +1119,5 @@ TEST_F(DecimalTest, ToStringSpecialValues)
EXPECT_DECIMAL_STREQ("-Infinity", Decimal::infinity(Negative));
EXPECT_DECIMAL_STREQ("NaN", Decimal::nan());
}
+
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698