Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182703002: Fix unit test style in Source/platform/, part 1. (Closed)

Created:
5 years, 6 months ago by tkent
Modified:
5 years, 6 months ago
Reviewers:
kochi
CC:
blink-reviews, krit, shans, rjwright, Rik, blink-reviews-animation_chromium.org, dshwang, jbroman, dcheng, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Justin Novosad, darktears, Stephen Chennney, rwlbuis, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix unit test style in Source/platform/, part 1. - namespace usage - ASSERT -> EXPECT - Fix EXPECT_EQ argument order BUG=498604 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196994

Patch Set 1 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -353 lines) Patch
M Source/platform/ClockTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/DecimalTest.cpp View 4 chunks +8 lines, -10 lines 0 comments Download
M Source/platform/DragImageTest.cpp View 4 chunks +2 lines, -8 lines 0 comments Download
M Source/platform/LayoutUnitTest.cpp View 1 chunk +185 lines, -187 lines 0 comments Download
M Source/platform/LifecycleContextTest.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M Source/platform/PODArenaTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/PurgeableVectorTest.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M Source/platform/SharedBufferTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/platform/TracedValueTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/animation/UnitBezierTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/clipboard/ClipboardUtilitiesTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/fonts/GlyphBufferTest.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/platform/fonts/GlyphPageTreeNodeTest.cpp View 9 chunks +12 lines, -8 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp View 7 chunks +63 lines, -66 lines 3 comments Download
M Source/platform/geometry/FloatBoxTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/geometry/FloatPointTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/geometry/FloatPolygonTest.cpp View 4 chunks +5 lines, -8 lines 0 comments Download
M Source/platform/geometry/FloatRoundedRectTest.cpp View 3 chunks +1 line, -8 lines 0 comments Download
M Source/platform/geometry/FloatSizeTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/geometry/RegionTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tkent
kochi@, would you review this please?
5 years, 6 months ago (2015-06-12 02:03:10 UTC) #3
kochi
https://codereview.chromium.org/1182703002/diff/20001/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp File Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp (right): https://codereview.chromium.org/1182703002/diff/20001/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp#newcode48 Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp:48: ASSERT_TRUE(shaper.runInfoForTesting(0, startIndex, numGlyphs, script)); Why not EXPECT_TRUE? (same for ...
5 years, 6 months ago (2015-06-12 02:22:20 UTC) #4
tkent
https://codereview.chromium.org/1182703002/diff/20001/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp File Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp (right): https://codereview.chromium.org/1182703002/diff/20001/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp#newcode48 Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp:48: ASSERT_TRUE(shaper.runInfoForTesting(0, startIndex, numGlyphs, script)); On 2015/06/12 02:22:20, Takayoshi Kochi ...
5 years, 6 months ago (2015-06-12 02:41:07 UTC) #5
kochi
lgtm https://codereview.chromium.org/1182703002/diff/20001/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp File Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp (right): https://codereview.chromium.org/1182703002/diff/20001/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp#newcode48 Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp:48: ASSERT_TRUE(shaper.runInfoForTesting(0, startIndex, numGlyphs, script)); On 2015/06/12 02:41:06, tkent ...
5 years, 6 months ago (2015-06-12 02:42:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182703002/20001
5 years, 6 months ago (2015-06-12 02:43:15 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 03:05:41 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196994

Powered by Google App Engine
This is Rietveld 408576698