Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 1182663009: [DevTools] Disable plugins when emulating mobile. (Closed)

Created:
5 years, 6 months ago by dgozman
Modified:
5 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Disable plugins when emulating mobile. BUG=438473 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197201

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M Source/web/DevToolsEmulator.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/DevToolsEmulator.cpp View 4 chunks +11 lines, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dgozman
Take a look please.
5 years, 6 months ago (2015-06-16 17:43:06 UTC) #2
pfeldman
lgtm
5 years, 6 months ago (2015-06-16 18:28:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182663009/1
5 years, 6 months ago (2015-06-16 18:41:07 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 21:26:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197201

Powered by Google App Engine
This is Rietveld 408576698