Typecheck const classes in the context of the constructor call.

tests/compiler/dart2js/type_variable_bound_test.dart

Index: tests/compiler/dart2js/type_variable_bound_test.dart
diff --git a/tests/compiler/dart2js/type_variable_bound_test.dart b/tests/compiler/dart2js/type_variable_bound_test.dart
index 6844abba0fdbc4bbf24f606147b36d5347863b97..6ba982cef376923a357da615e9247b0506d5371e 100644
--- a/tests/compiler/dart2js/type_variable_bound_test.dart
+++ b/tests/compiler/dart2js/type_variable_bound_test.dart
@@ -9,7 +9,7 @@ import "package:expect/expect.dart";
 
 Future compile(String source) {
   Uri uri = Uri.parse('test:code');
-  var compiler = compilerFor(source, uri, analyzeOnly: true);
+  var compiler = compilerFor(source, uri, analyzeOnly: true, enableTypeAssertions: true);

[Johnni Winther, 2015/06/17 06:56:29]

Long line.

[Harry Terkelsen, 2015/08/10 23:49:34]

Done.

   compiler.diagnosticHandler = createHandler(compiler, source);
   return compiler.runCompiler(uri).then((_) {
     return compiler;
@@ -214,6 +214,39 @@ void main() {
                 MessageKind.INVALID_TYPE_VARIABLE_BOUND]);
 }
 
+test10() {
+  test(r"""
+class A {
+  const A();
+}
+class Test<T extends A> {
+  final T x = const A();
+  const Test();
+}
+main() {
+  print(const Test<A>());
+}
+""");
+}
+
+test11() {
+  test(r"""
+class A {
+  const A();
+}
+class B extends A {
+  const B();
+}
+class Test<T extends A> {
+  final T x = const A();

[Siggi Cherem (dart-lang), 2015/06/16 18:19:06]

mmm... we got a tricky situation here on how to report the error. 

It seems like we are reporting the error on this line, but the actual problem is
on the const Test<B>() below where we actually decide what T is. I wonder if we
should move the error location there and provide some context about this line?
(for example like we do with duplicate definitions and show both the duplicate
and the existing definition)

[Harry Terkelsen, 2015/08/10 23:49:35]

I agree, but I added a TODO rather than implement this now. The issue is that
you only want to put the error on the construction invocation if the type error
is due to the concrete type variable in the constructor invocation.

+  const Test();
+}
+main() {
+  print(const Test<B>());
+}
+""", errors: [MessageKind.NOT_ASSIGNABLE, MessageKind.NOT_ASSIGNABLE]);

[Siggi Cherem (dart-lang), 2015/06/16 18:19:06]

not sure if it's worth it, but maybe we can add some extra logic to check where
the error is reported (similar to test2?)

+}
+
 main() {
   test1();
   test2();
@@ -224,4 +257,6 @@ main() {
   test7();
   test8();
   test9();
+  test10();
+  test11();
 }