Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1182663007: Fix some build symbol configuration. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some build symbol configuration. Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant. Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission. Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team. Reland of https://codereview.chromium.org/1179393004/ TBR=thakis@chromium.org Committed: https://crrev.com/07d847b1c5451748f16f4e7973ce8ef9078d47a2 Cr-Commit-Position: refs/heads/master@{#334690}

Patch Set 1 : Original patch #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -41 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D build/linux/dump_app_syms View 1 chunk +0 lines, -36 lines 0 comments Download
A build/linux/dump_app_syms.py View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/BUILD.gn View 1 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
brettw
5 years, 6 months ago (2015-06-16 16:36:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182663007/20001
5 years, 6 months ago (2015-06-16 16:37:07 UTC) #4
Nico
lgtm
5 years, 6 months ago (2015-06-16 16:38:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/70273)
5 years, 6 months ago (2015-06-16 18:07:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182663007/20001
5 years, 6 months ago (2015-06-16 20:11:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 20:59:12 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/07d847b1c5451748f16f4e7973ce8ef9078d47a2 Cr-Commit-Position: refs/heads/master@{#334690}
5 years, 6 months ago (2015-06-16 21:00:10 UTC) #11
brettw
5 years, 6 months ago (2015-06-16 23:28:45 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1187233002/ by brettw@chromium.org.

The reason for reverting is: Broke Linux clobber:

https://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/bui....

Powered by Google App Engine
This is Rietveld 408576698