lib/src/codegen/html_codegen.dart - Issue 1182653002: Refactor runtime into libraries, better type reps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/html_codegen.dart

Issue 1182653002: Refactor runtime into libraries, better type reps (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Address comments 2 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/html_codegen.dart

diff --git a/lib/src/codegen/html_codegen.dart b/lib/src/codegen/html_codegen.dart

index 31f25600c207a0262c0729f0ae47f96fee17974f..48ef45626ccd2d4f649928268c0911114b368008 100644

--- a/lib/src/codegen/html_codegen.dart

+++ b/lib/src/codegen/html_codegen.dart

@@ -104,7 +104,7 @@ Node _invokeMain(String mainLibraryName) {

? 'console.error("dev_compiler error: main was not generated");'

// TODO(vsm): Can we simplify this?

// See: https://github.com/dart-lang/dev_compiler/issues/164

- : "dart.start('$mainLibraryName');";

+ : "dart_library.start('$mainLibraryName');";

return parseFragment('<script>$code</script>\n');

}

« no previous file with comments | « lib/runtime/dart_utils.js ('k') | lib/src/codegen/js_codegen.dart » ('j') | no next file with comments »