Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: tool/sdk_expected_errors.txt

Issue 1182653002: Refactor runtime into libraries, better type reps (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Address comments 2 Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/codegen/expect/try_catch.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 warning: line 80, column 12 of dart:_interceptors/js_array.dart: [DownCastCompos ite] JS('var', r'#.pop()', this) (dynamic) will need runtime check to cast to ty pe E 1 warning: line 80, column 12 of dart:_interceptors/js_array.dart: [DownCastCompos ite] JS('var', r'#.pop()', this) (dynamic) will need runtime check to cast to ty pe E
2 return JS('var', r'#.pop()', this); 2 return JS('var', r'#.pop()', this);
3 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ 3 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
4 warning: line 125, column 9 of dart:_interceptors/js_array.dart: [DownCastCompos ite] JS('', '#[#]', this, i) (dynamic) will need runtime check to cast to type E 4 warning: line 125, column 9 of dart:_interceptors/js_array.dart: [DownCastCompos ite] JS('', '#[#]', this, i) (dynamic) will need runtime check to cast to type E
5 f(JS('', '#[#]', this, i)); 5 f(JS('', '#[#]', this, i));
6 ^^^^^^^^^^^^^^^^^^^^^^^ 6 ^^^^^^^^^^^^^^^^^^^^^^^
7 warning: line 161, column 12 of dart:_interceptors/js_array.dart: [DownCastCompo site] IterableMixinWorkaround.reduce(this, combine) (dynamic) will need runtime check to cast to type E 7 warning: line 161, column 12 of dart:_interceptors/js_array.dart: [DownCastCompo site] IterableMixinWorkaround.reduce(this, combine) (dynamic) will need runtime check to cast to type E
8 return IterableMixinWorkaround.reduce(this, combine); 8 return IterableMixinWorkaround.reduce(this, combine);
9 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 9 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
10 warning: line 169, column 12 of dart:_interceptors/js_array.dart: [DownCastCompo site] IterableMixinWorkaround.firstWhere(this, test, orElse) (dynamic) will need runtime check to cast to type E 10 warning: line 169, column 12 of dart:_interceptors/js_array.dart: [DownCastCompo site] IterableMixinWorkaround.firstWhere(this, test, orElse) (dynamic) will need runtime check to cast to type E
(...skipping 655 matching lines...) Expand 10 before | Expand all | Expand 10 after
666 ^^^^^^ 666 ^^^^^^
667 warning: line 357, column 29 of dart:_isolate_helper/isolate_serialization.dart: [DownCastImplicit] fields (List<dynamic>) will need runtime check to cast to ty pe JSArray<dynamic> 667 warning: line 357, column 29 of dart:_isolate_helper/isolate_serialization.dart: [DownCastImplicit] fields (List<dynamic>) will need runtime check to cast to ty pe JSArray<dynamic>
668 deserializeArrayInPlace(fields); 668 deserializeArrayInPlace(fields);
669 ^^^^^^ 669 ^^^^^^
670 warning: line 20, column 39 of dart:async/async_error.dart: [DownCastImplicit] e rrorHandler (Function) will need runtime check to cast to type (dynamic) → dynam ic 670 warning: line 20, column 39 of dart:async/async_error.dart: [DownCastImplicit] e rrorHandler (Function) will need runtime check to cast to type (dynamic) → dynam ic
671 return zone.registerUnaryCallback(errorHandler); 671 return zone.registerUnaryCallback(errorHandler);
672 ^^^^^^^^^^^^ 672 ^^^^^^^^^^^^
673 severe: line 211, column 38 of dart:async/broadcast_stream_controller.dart: [Ana lyzerError] The getter '_next' is not defined for the class 'StreamSubscription< T>' 673 severe: line 211, column 38 of dart:async/broadcast_stream_controller.dart: [Ana lyzerError] The getter '_next' is not defined for the class 'StreamSubscription< T>'
674 assert(!identical(subscription._next, subscription)); 674 assert(!identical(subscription._next, subscription));
675 ^^^^^ 675 ^^^^^
676 severe: line 209, column 20 of dart:async/broadcast_stream_controller.dart: [Ana lyzerError] The method '_setRemoveAfterFiring' is not defined for the class 'Str eamSubscription<T>'
677 subscription._setRemoveAfterFiring();
678 ^^^^^^^^^^^^^^^^^^^^^
676 severe: line 207, column 36 of dart:async/broadcast_stream_controller.dart: [Ana lyzerError] The getter '_next' is not defined for the class 'StreamSubscription< T>' 679 severe: line 207, column 36 of dart:async/broadcast_stream_controller.dart: [Ana lyzerError] The getter '_next' is not defined for the class 'StreamSubscription< T>'
677 assert(!identical(subscription._next, subscription)); 680 assert(!identical(subscription._next, subscription));
678 ^^^^^ 681 ^^^^^
679 severe: line 209, column 20 of dart:async/broadcast_stream_controller.dart: [Ana lyzerError] The method '_setRemoveAfterFiring' is not defined for the class 'Str eamSubscription<T>'
680 subscription._setRemoveAfterFiring();
681 ^^^^^^^^^^^^^^^^^^^^^
682 severe: line 208, column 22 of dart:async/broadcast_stream_controller.dart: [Ana lyzerError] The getter '_isFiring' is not defined for the class 'StreamSubscript ion<T>' 682 severe: line 208, column 22 of dart:async/broadcast_stream_controller.dart: [Ana lyzerError] The getter '_isFiring' is not defined for the class 'StreamSubscript ion<T>'
683 if (subscription._isFiring) { 683 if (subscription._isFiring) {
684 ^^^^^^^^^ 684 ^^^^^^^^^
685 severe: line 206, column 32 of dart:async/broadcast_stream_controller.dart: [Ana lyzerError] The getter '_next' is not defined for the class 'StreamSubscription< T>' 685 severe: line 206, column 32 of dart:async/broadcast_stream_controller.dart: [Ana lyzerError] The getter '_next' is not defined for the class 'StreamSubscription< T>'
686 if (identical(subscription._next, subscription)) return null; 686 if (identical(subscription._next, subscription)) return null;
687 ^^^^^ 687 ^^^^^
688 warning: line 8, column 67 of dart:async/broadcast_stream_controller.dart: [Down CastComposite] controller (_StreamControllerLifecycle<dynamic>) will need runtim e check to cast to type _StreamControllerLifecycle<T> 688 warning: line 8, column 67 of dart:async/broadcast_stream_controller.dart: [Down CastComposite] controller (_StreamControllerLifecycle<dynamic>) will need runtim e check to cast to type _StreamControllerLifecycle<T>
689 _BroadcastStream(_StreamControllerLifecycle controller) : super(controller); 689 _BroadcastStream(_StreamControllerLifecycle controller) : super(controller);
690 ^^^^^^^^^^ 690 ^^^^^^^^^^
691 warning: line 36, column 15 of dart:async/broadcast_stream_controller.dart: [Dow nCastComposite] controller (_StreamControllerLifecycle<dynamic>) will need runti me check to cast to type _StreamControllerLifecycle<T> 691 warning: line 36, column 15 of dart:async/broadcast_stream_controller.dart: [Dow nCastComposite] controller (_StreamControllerLifecycle<dynamic>) will need runti me check to cast to type _StreamControllerLifecycle<T>
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
768 ^^^^^^^^^^^^^ 768 ^^^^^^^^^^^^^
769 warning: line 66, column 61 of dart:async/schedule_microtask.dart: [DownCastComp osite] callback (dynamic) will need runtime check to cast to type () → void 769 warning: line 66, column 61 of dart:async/schedule_microtask.dart: [DownCastComp osite] callback (dynamic) will need runtime check to cast to type () → void
770 _nextCallback = _lastCallback = new _AsyncCallbackEntry(callback); 770 _nextCallback = _lastCallback = new _AsyncCallbackEntry(callback);
771 ^^^^^^^^ 771 ^^^^^^^^
772 warning: line 71, column 60 of dart:async/schedule_microtask.dart: [DownCastComp osite] callback (dynamic) will need runtime check to cast to type () → void 772 warning: line 71, column 60 of dart:async/schedule_microtask.dart: [DownCastComp osite] callback (dynamic) will need runtime check to cast to type () → void
773 _AsyncCallbackEntry newEntry = new _AsyncCallbackEntry(callback); 773 _AsyncCallbackEntry newEntry = new _AsyncCallbackEntry(callback);
774 ^^^^^^^^ 774 ^^^^^^^^
775 warning: line 84, column 55 of dart:async/schedule_microtask.dart: [DownCastComp osite] callback (dynamic) will need runtime check to cast to type () → void 775 warning: line 84, column 55 of dart:async/schedule_microtask.dart: [DownCastComp osite] callback (dynamic) will need runtime check to cast to type () → void
776 _AsyncCallbackEntry entry = new _AsyncCallbackEntry(callback); 776 _AsyncCallbackEntry entry = new _AsyncCallbackEntry(callback);
777 ^^^^^^^^ 777 ^^^^^^^^
778 severe: line 321, column 34 of dart:async/stream.dart: [AnalyzerError] The gette r '_addError' is not defined for the class 'StreamController'
779 final addError = eventSink._addError;
780 ^^^^^^^^^
781 severe: line 1227, column 17 of dart:async/stream.dart: [AnalyzerError] The meth od '_addError' is not defined for the class 'StreamController' 778 severe: line 1227, column 17 of dart:async/stream.dart: [AnalyzerError] The meth od '_addError' is not defined for the class 'StreamController'
782 eventSink._addError(error, stackTrace); // Avoid Zone error replacement. 779 eventSink._addError(error, stackTrace); // Avoid Zone error replacement.
783 ^^^^^^^^^ 780 ^^^^^^^^^
784 severe: line 396, column 30 of dart:async/stream.dart: [AnalyzerError] The gette r '_addError' is not defined for the class 'StreamController' 781 severe: line 396, column 30 of dart:async/stream.dart: [AnalyzerError] The gette r '_addError' is not defined for the class 'StreamController'
785 onError: eventSink._addError, // Avoid Zone error replacement. 782 onError: eventSink._addError, // Avoid Zone error replacement.
786 ^^^^^^^^^ 783 ^^^^^^^^^
784 severe: line 321, column 34 of dart:async/stream.dart: [AnalyzerError] The gette r '_addError' is not defined for the class 'StreamController'
785 final addError = eventSink._addError;
786 ^^^^^^^^^
787 warning: line 90, column 25 of dart:async/stream.dart: [DownCastComposite] value (dynamic) will need runtime check to cast to type T 787 warning: line 90, column 25 of dart:async/stream.dart: [DownCastComposite] value (dynamic) will need runtime check to cast to type T
788 controller._add(value); 788 controller._add(value);
789 ^^^^^ 789 ^^^^^
790 warning: line 217, column 41 of dart:async/stream.dart: [DownCastComposite] mapS ink ((EventSink<T>) → EventSink<dynamic>) will need runtime check to cast to typ e (EventSink<dynamic>) → EventSink 790 warning: line 217, column 41 of dart:async/stream.dart: [DownCastComposite] mapS ink ((EventSink<T>) → EventSink<dynamic>) will need runtime check to cast to typ e (EventSink<dynamic>) → EventSink
791 return new _BoundSinkStream(source, mapSink); 791 return new _BoundSinkStream(source, mapSink);
792 ^^^^^^^ 792 ^^^^^^^
793 warning: line 249, column 44 of dart:async/stream.dart: [DownCastComposite] onLi sten ((StreamSubscription<T>) → void) will need runtime check to cast to type (S treamSubscription<dynamic>) → void 793 warning: line 249, column 44 of dart:async/stream.dart: [DownCastComposite] onLi sten ((StreamSubscription<T>) → void) will need runtime check to cast to type (S treamSubscription<dynamic>) → void
794 return new _AsBroadcastStream<T>(this, onListen, onCancel); 794 return new _AsBroadcastStream<T>(this, onListen, onCancel);
795 ^^^^^^^^ 795 ^^^^^^^^
796 warning: line 249, column 54 of dart:async/stream.dart: [DownCastComposite] onCa ncel ((StreamSubscription<T>) → void) will need runtime check to cast to type (S treamSubscription<dynamic>) → void 796 warning: line 249, column 54 of dart:async/stream.dart: [DownCastComposite] onCa ncel ((StreamSubscription<T>) → void) will need runtime check to cast to type (S treamSubscription<dynamic>) → void
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
1068 ^^^^^^^^^^^^^^^^ 1068 ^^^^^^^^^^^^^^^^
1069 warning: line 1869, column 12 of dart:core/uri.dart: [DownCastComposite] query.s plit("&").fold({}, (map, element) {int index = element.indexOf("="); if (index = = -1) {if (element != "") {map[decodeQueryComponent(element, encoding: encoding) ] = "";}} else if (index != 0) {var key = element.substring(0, index); var value = element.substring(index + 1); map[Uri.decodeQueryComponent(key, encoding: enc oding)] = decodeQueryComponent(value, encoding: encoding);} return map;}) (dynam ic) will need runtime check to cast to type Map<String, String> 1069 warning: line 1869, column 12 of dart:core/uri.dart: [DownCastComposite] query.s plit("&").fold({}, (map, element) {int index = element.indexOf("="); if (index = = -1) {if (element != "") {map[decodeQueryComponent(element, encoding: encoding) ] = "";}} else if (index != 0) {var key = element.substring(0, index); var value = element.substring(index + 1); map[Uri.decodeQueryComponent(key, encoding: enc oding)] = decodeQueryComponent(value, encoding: encoding);} return map;}) (dynam ic) will need runtime check to cast to type Map<String, String>
1070 return query.split("&").fold({}, (map, element) { 1070 return query.split("&").fold({}, (map, element) {
1071 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 1071 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1072 warning: line 1901, column 12 of dart:core/uri.dart: [DownCastComposite] bytes.m ap((byteString) {int byte = int.parse(byteString); if (byte < 0 || byte > 255) { error('each part must be in the range of `0..255`');} return byte;}).toList() (L ist<dynamic>) will need runtime check to cast to type List<int> 1072 warning: line 1901, column 12 of dart:core/uri.dart: [DownCastComposite] bytes.m ap((byteString) {int byte = int.parse(byteString); if (byte < 0 || byte > 255) { error('each part must be in the range of `0..255`');} return byte;}).toList() (L ist<dynamic>) will need runtime check to cast to type List<int>
1073 return bytes 1073 return bytes
1074 ^^^^^^ 1074 ^^^^^^
1075 warning: line 2023, column 12 of dart:core/uri.dart: [DownCastComposite] bytes ( List<dynamic>) will need runtime check to cast to type List<int> 1075 warning: line 2023, column 12 of dart:core/uri.dart: [DownCastComposite] bytes ( List<dynamic>) will need runtime check to cast to type List<int>
1076 return bytes; 1076 return bytes;
1077 ^^^^^ 1077 ^^^^^
OLDNEW
« no previous file with comments | « test/codegen/expect/try_catch.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698