Issue 118263002: Split out common parsing code for Position/Size VTT cue settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118263002: Split out common parsing code for Position/Size VTT cue settings (Closed)

Created:
7 years ago by fs

Modified:
7 years ago

Reviewers:
jochen (gone - plz use gerrit), Nate Chapin, Mike West

CC:
blink-reviews, nessy, philipj_slow, gasubic, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Split out common parsing code for Position/Size VTT cue settings While in the vicinity, also reposition the braces for the cases in the switch. BUG=305317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164095

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -58 lines)			Patch
	M	Source/core/html/track/vtt/VTTCue.cpp	View		5 chunks	+46 lines, -58 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/118263002/1

7 years ago (2013-12-18 14:59:13 UTC) #3

Message was sent while issue was closed.

Change committed as 164095