Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1182623002: [Android] Make adb_install_apk use the device blacklist. (Closed)

Created:
5 years, 6 months ago by jbudorick
Modified:
5 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Make adb_install_apk use the device blacklist. BUG=498232 Committed: https://crrev.com/7197964049d0db49c02421859b6dafc7bfdc516e Cr-Commit-Position: refs/heads/master@{#334073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -59 lines) Patch
M build/android/adb_install_apk.py View 1 chunk +62 lines, -59 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jbudorick
Also did some general cleaning, since I was in here.
5 years, 6 months ago (2015-06-11 20:25:30 UTC) #2
navabi1
lgtm thanks for the cleanup
5 years, 6 months ago (2015-06-11 21:47:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182623002/1
5 years, 6 months ago (2015-06-11 21:59:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 23:27:36 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7197964049d0db49c02421859b6dafc7bfdc516e Cr-Commit-Position: refs/heads/master@{#334073}
5 years, 6 months ago (2015-06-11 23:28:41 UTC) #7
jbudorick
5 years, 6 months ago (2015-06-12 03:52:10 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1186443002/ by jbudorick@chromium.org.

The reason for reverting is: broke at least chromium.gpu:
http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%....

Powered by Google App Engine
This is Rietveld 408576698