Issue 11826068: ash: Disable window caption buttons in immersive mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11826068: ash: Disable window caption buttons in immersive mode (Closed)

Created:
7 years, 11 months ago by James Cook

Modified:
7 years, 11 months ago

Reviewers:
pkotwicz, sky

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Disable window caption buttons in immersive mode Set them invisible when immersive mode is enabled, but show them when we reveal the toolbar. Also ensure the caption buttons don't reserve too much horizontal space when the immersive mode button is invisible. Otherwise the tab strip doesn't have enough space. BUG=168855 TEST=added browser_tests BrowserNonClientFrameViewAshTest.ImmersiveMode Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176751

Patch Set 1 #

Patch Set 2 : trivial rebase #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -3 lines)			Patch
M	ash/wm/frame_painter.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc	View		3 chunks	+45 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/immersive_mode_controller.cc	View	1	3 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

James Cook

Please take a look. This is where the immersive mode button is wired into the ...

7 years, 11 months ago (2013-01-10 23:42:43 UTC) #1

pkotwicz

I'll take a look at this on Friday night. Sorry for the slowness

7 years, 11 months ago (2013-01-11 14:53:52 UTC) #2

James Cook

Sky, can I get OWNERS approval? (Since my ownership of frame/ hasn't happened yet. :-)

7 years, 11 months ago (2013-01-12 05:59:37 UTC) #4

commit-bot: I haz the power

7 years, 11 months ago (2013-01-14 16:47:32 UTC) #6

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/11826068/1

Expand Messages | Collapse Messages