Issue 11826062: Enable debugallocation by default (try 3 or so).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11826062: Enable debugallocation by default (try 3 or so). (Closed)

Created:
7 years, 11 months ago by Paweł Hajdan Jr.

Modified:
7 years, 11 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, MAD, erikwright+watch_chromium.org, Ilya Sherman, dmikurube+memory_chromium.org, jar (doing other things)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GTTF: Enable debugallocation by default (try 3 or so). Also remove invalid ANNOTATE_LEAKING_OBJECT_PTR annotation for an object that _does_ get deleted. This is for now disabled on Windows because of tsan compile issues. TBR=jar BUG=30715 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176138

Patch Set 1 #

Patch Set 2 : disable on Windows #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	base/allocator/allocator.gyp	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
	M	base/metrics/statistics_recorder.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

7 years, 11 months ago (2013-01-10 20:18:21 UTC) #1

Message was sent while issue was closed.

TBR

The issue with debugallocation+heapcheck is this at the end of the test
(base_unittests):

Object at 0x7f961a99d100 of 56 bytes from an IgnoreObject() has disappeared
Thread finding failed with -1 errno=14
Thread finding callback was interrupted or crashed; can't fix this
Received signal 11
 [0x0000008659c7] base::debug::StackTrace::StackTrace()
 [0x0000008650c8] base::debug::(anonymous namespace)::StackDumpSignalHandler()
 [0x7f9623b7f4a0] <unknown>
 [0x000000bdbd63] tcmalloc::Abort()
 [0x000000ba6d2f] LogPrintf()
 [0x000000ba6e25] RAW_LOG()
 [0x000000ba36c3] HeapLeakChecker::IgnoreAllLiveObjectsLocked()
 [0x000000ba49e9] HeapLeakChecker::DoNoLeaks()
 [0x000000ba5a05] HeapLeakChecker::NoGlobalLeaksMaybeSymbolize()
 [0x000000ba5afc] HeapLeakChecker::DoMainHeapCheck()
 [0x000000ba51ef] HeapLeakChecker_RunHeapCleanups()
 [0x000000ba5997] (anonymous namespace)::google_destruct_module_init_start()
 [0x000000ba6fac] GoogleInitializer::~GoogleInitializer()
 [0x7f9623b84901] <unknown>
 [0x7f9623b84985] <unknown>
 [0x7f9623b6a774] <unknown>
 [0x00000040c0f9] <unknown>
  r8: 276e6163203b6465  r9: ffffffffffffffff r10: 687361726320726f r11:
0000000000000202
 r12: 0000000000000001 r13: 0000000000000001 r14: 0000000000000000 r15:
0000000000000000
  di: 0000000000bdbd44  si: 0000000000ba6d2f  bp: 00007fff2e03c710  bx:
00007f96140a1120
  dx: 0000000000000043  ax: 0000000000000039  cx: 00007f9623c38ed9  sp:
00007fff2e03c710
  ip: 0000000000bdbd63 efl: 0000000000010202 cgf: 0000000000000033 erf:
0000000000000006
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000039

This change enabled debugallocation by default in Debug build on non-Windows,
and for heapcheck please see
http://www.chromium.org/developers/how-tos/using-the-heap-leak-checker . Note
you can repro with just "env HEAPCHECK=normal out/Debug/base_unittests" . Please
let me know if you have more questions.

Expand Messages | Collapse Messages