Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: src/ic.cc

Issue 11826051: Better --trace-ic output for UnaryOpICs, matching other IC types (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2431 matching lines...) Expand 10 before | Expand all | Expand 10 after
2442 UnaryOpIC::TypeInfo previous_type = 2442 UnaryOpIC::TypeInfo previous_type =
2443 static_cast<UnaryOpIC::TypeInfo>(args.smi_at(3)); 2443 static_cast<UnaryOpIC::TypeInfo>(args.smi_at(3));
2444 2444
2445 UnaryOpIC::TypeInfo type = UnaryOpIC::GetTypeInfo(operand); 2445 UnaryOpIC::TypeInfo type = UnaryOpIC::GetTypeInfo(operand);
2446 type = UnaryOpIC::ComputeNewType(type, previous_type); 2446 type = UnaryOpIC::ComputeNewType(type, previous_type);
2447 2447
2448 UnaryOpStub stub(op, mode, type); 2448 UnaryOpStub stub(op, mode, type);
2449 Handle<Code> code = stub.GetCode(); 2449 Handle<Code> code = stub.GetCode();
2450 if (!code.is_null()) { 2450 if (!code.is_null()) {
2451 if (FLAG_trace_ic) { 2451 if (FLAG_trace_ic) {
2452 PrintF("[UnaryOpIC (%s->%s)#%s]\n", 2452 PrintF("[UnaryOpIC in ");
2453 JavaScriptFrame::PrintTop(stdout, false, true);
2454 PrintF(" (%s->%s)#%s @ %p]\n",
2453 UnaryOpIC::GetName(previous_type), 2455 UnaryOpIC::GetName(previous_type),
2454 UnaryOpIC::GetName(type), 2456 UnaryOpIC::GetName(type),
2455 Token::Name(op)); 2457 Token::Name(op),
2458 static_cast<void*>(*code));
2456 } 2459 }
2457 UnaryOpIC ic(isolate); 2460 UnaryOpIC ic(isolate);
2458 ic.patch(*code); 2461 ic.patch(*code);
2459 } 2462 }
2460 2463
2461 Handle<JSBuiltinsObject> builtins = Handle<JSBuiltinsObject>( 2464 Handle<JSBuiltinsObject> builtins = Handle<JSBuiltinsObject>(
2462 isolate->thread_local_top()->context_->builtins(), isolate); 2465 isolate->thread_local_top()->context_->builtins(), isolate);
2463 Object* builtin = NULL; // Initialization calms down the compiler. 2466 Object* builtin = NULL; // Initialization calms down the compiler.
2464 switch (op) { 2467 switch (op) {
2465 case Token::SUB: 2468 case Token::SUB:
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
2857 #undef ADDR 2860 #undef ADDR
2858 }; 2861 };
2859 2862
2860 2863
2861 Address IC::AddressFromUtilityId(IC::UtilityId id) { 2864 Address IC::AddressFromUtilityId(IC::UtilityId id) {
2862 return IC_utilities[id]; 2865 return IC_utilities[id];
2863 } 2866 }
2864 2867
2865 2868
2866 } } // namespace v8::internal 2869 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698