Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 11826040: Roll Skia DEPS to r7112 (Closed)

Created:
7 years, 11 months ago by robertphillips
Modified:
7 years, 11 months ago
Reviewers:
reed1
CC:
chromium-reviews, skia-dev_google.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
robertphillips
I believe this is 'good'. The discrepancies between the roll and control are: mac_asan roll: ...
7 years, 11 months ago (2013-01-10 13:28:04 UTC) #1
bsalomon
7 years, 11 months ago (2013-01-10 14:03:49 UTC) #2
On 2013/01/10 13:28:04, robertphillips wrote:
> I believe this is 'good'. The discrepancies between the roll and control are:
> 
> mac_asan
>    roll:
>             interactive_ui_tests failed 7
>                 CommitInNewTab
>                 TestCrashTabWithPermissionInfobar
>                 AddAndClosePanel
>                 DragNarrowPanel
>                 DragWidePanel
>                 ExpandAndCollapsePanel
>                 MenuItems
>    control:
>             green
> 
> mac_layout_rel
>    roll:    compile failed - undefined symbol
>    control: compile failed - undefined symbol
> 
> win_layout
>    roll:
>             webkit_tests 1078 fixable (0 skipped) failed 11
>                 canvas-fallback-content-2.html
>                 computed-style-during-delay.html
>                 insert-list-xml.xhtml
>                 paste-noscript-xhtml.xhtml
>                 paste-xml.xhtml
>                 justify-without-enclosing-block.xhtml
>                 context-release-upon-reload.html
>                 state-restore-per-form.html
> **************************************
>                 context-release-upon-reload.html
>                 gradient-background-leakage-hidpi.html
>                 full-screen-video-from-region.html
>    control:
>             webkit_tests 1068 fixable (0 skipped) failed 10
>                 canvas-fallback-content-2.html
>                 computed-style-during-delay.html
>                 insert-list-xml.xhtml
>                 paste-noscript-xhtml.xhtml
>                 paste-xml.xhtml
>                 justify-without-enclosing-block.xhtml
>                 context-release-upon-reload.html
>                 context-release-upon-reload.html
>                 gradient-background-leakage-hidpi.html
>                 full-screen-video-from-region.html
> 
> win_layout_rel
>    roll:
>             webkit_tests 997 fixable (0 skipped) failed 5
>                 canvas-fallback-content-2.html
>                 feComponentTransfer-Table.svg
> *************************************
>                 automatic-pull-node.html
> ******************************************
>                 gradient-background-leakage-hidpi.html
>                 full-screen-video-from-region.html
>    control:
>             webkit_tests 996 fixable (0 skipped) failed 4
>                 canvas-fallback-content-2.html
>                 getPutImageDataPairTest.html
>                 gradient-background-leakage-hidpi.html
>                 full-screen-video-from-region.html

lgtm. The only failure that gives me a little pause is
feComponentTransfer-Table.svg. But the dashboard shows it has been flaky and
there is a WK bug filed about it.

Powered by Google App Engine
This is Rietveld 408576698